Changed OfferWithAnOffset test's termOffset to be FRAME_ALIGNMENT-aligned#145
Open
strangelydim wants to merge 1 commit intomasterfrom
Open
Changed OfferWithAnOffset test's termOffset to be FRAME_ALIGNMENT-aligned#145strangelydim wants to merge 1 commit intomasterfrom
strangelydim wants to merge 1 commit intomasterfrom
Conversation
…gned so test does not crash on ARM64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test was crashing on ARM64 due to unaligned write. I don't think this change invalidates or changes what the test was actually designed to test, however, and I don't think real Aeron user code should ever be able to write to a non-FRAME_ALIGNMENT-aligned buffer anyway.