Skip to content

Extending section on fixed-point types#1317

Merged
gusthoff merged 31 commits intoAdaCore:mainfrom
gusthoff:content/advanced_ada/new_content/numerics/fixed_point_types/20260215
Apr 21, 2026
Merged

Extending section on fixed-point types#1317
gusthoff merged 31 commits intoAdaCore:mainfrom
gusthoff:content/advanced_ada/new_content/numerics/fixed_point_types/20260215

Conversation

@gusthoff
Copy link
Copy Markdown
Collaborator

  • Adding subsections on ordinary fixed-point types.
  • Adding subsection on type conversions and machine representation.
  • Adding subsection on integer multiplication and division.

@gusthoff gusthoff added the new section Section using new content label Feb 16, 2026
@gusthoff gusthoff force-pushed the content/advanced_ada/new_content/numerics/fixed_point_types/20260215 branch from c5abbcb to 96719a8 Compare February 16, 2026 03:38
@gusthoff gusthoff force-pushed the content/advanced_ada/new_content/numerics/fixed_point_types/20260215 branch 2 times, most recently from 021a0a2 to defd5b3 Compare March 20, 2026 14:48
@gusthoff gusthoff requested a review from swbaird March 20, 2026 14:48
Copy link
Copy Markdown

@swbaird swbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good stuff here.
I've got a few comments.

Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst Outdated
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst Outdated
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst Outdated
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst
Comment thread content/courses/advanced-ada/parts/data_types/numerics.rst Outdated
gusthoff added 24 commits April 19, 2026 21:54
… types

Adding subsection on multiplication/division and ordinary fixed-point
types in the context of universal fixed types	.
@gusthoff gusthoff force-pushed the content/advanced_ada/new_content/numerics/fixed_point_types/20260215 branch from 744b19f to 6f32b2e Compare April 19, 2026 19:54
@gusthoff gusthoff requested a review from swbaird April 19, 2026 20:08
swbaird
swbaird previously approved these changes Apr 20, 2026
Copy link
Copy Markdown

@swbaird swbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

generic
type T_Fixed is delta <>;
procedure Gen_Show_Type_Info
(Dummy : T_Fixed;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your call, but IMO an ignored parameter just to guide name resolution seems less intuitive than using two different names.

Copy link
Copy Markdown

@swbaird swbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gusthoff gusthoff merged commit de54728 into AdaCore:main Apr 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new section Section using new content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants