test(e2e): harden syncToggleReceivesRealTap with bounded tap retry

[TimeToBuildBob]

Problem

NativeWindowInsetsTest.syncToggleReceivesRealTap continues to fail intermittently
in Test E2E (29) even after the UiAutomator-node fix (#266) added awaitSyncEnabled:

date	run	notes
2026-09-14	35185908412	no ANR; unrelated diff
2026-09-16	35080080197	ANR in com.android.systemui — tap eaten by dialog
2026-09-17	35196333754	no ANR; master post-merge
2026-09-17	35219470515	no ANR; #273 head

The ANR class is a known emulator flake. The no-ANR class has a different
mechanism: the tap lands while SyncSettingsActivity is still applying async
preference state, so the switch is laid out but not yet interactive — the click
is silently ignored and the 5 s poll expires unchanged.

Fix

Add tapUntilPrefChanges to replace the tapViewCenter + awaitSyncEnabled
pair:

1. Pre-tap interactivity wait: polls (bounded 2 s) for isEnabled == true
   and stable bounds across two consecutive 50 ms samples before injecting the tap.
2. Per-attempt poll: 2 s (100 ms intervals) for the preference to flip.
3. Bounded retry: up to 3 attempts before the test fails. A genuinely broken
   toggle still fails — retries tolerate input timing, not a bad toggle.

Production code is unchanged. The now-unused awaitSyncEnabled helper is removed.

Related

• test(e2e): tap the sync switch by view bounds instead of a uiautomator lookup #266 — first fix (UiAutomator → tap-by-bounds + poll)
• test(e2e): wait for the rotated layout before post-rotation inset assertion #282 — rotation-test hardening (same bounded-poll pattern)
• fix(android): migrate unsanitized hostname after sanitizer change #273 — the PR whose E2E hit the no-ANR recurrence

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues identified.

Summary

This PR hardens the Android end-to-end sync-toggle test against emulator timing flakes.

• Waits for the toggle to become enabled with stable bounds before tapping.
• Retries within bounded readiness and preference-polling windows.
• Avoids reversing a preference update that completes after an earlier polling deadline.
• Fails clearly when no valid tap can be injected.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Start attempt] --> B{Retry attempt?}
    B -->|Yes| C[Wait for device idle]
    C --> D{Preference already expected?}
    D -->|Yes| Z[Return success]
    D -->|No| E[Poll enabled state and stable bounds]
    B -->|No| E
    E --> F{Ready within 2 seconds?}
    F -->|No| G[Skip tap and start next attempt]
    F -->|Yes| H[Tap view center]
    H --> I[Poll preference for bounded interval]
    I --> J{Preference changed?}
    J -->|Yes| Z
    J -->|No| G
    G --> K{Attempts remain?}
    K -->|Yes| A
    K -->|No, no taps| L[Fail with readiness message]
    K -->|No, tap occurred| M[Fail preference assertion]

Loading

_{Reviews (2) · Last reviewed commit: "fix(e2e): don't reverse late taps or tap..."}

[TimeToBuildBob]

🤖 AI code review

Replaces the tapViewCenter + awaitSyncEnabled pair in NativeWindowInsetsTest.syncToggleReceivesRealTap with a new tapUntilPrefChanges helper that waits for the view to be enabled and bounds-stable, polls for the preference flip, and retries the tap up to maxAttempts times. Removes the old awaitSyncEnabled helper and updates the test to call the new helper for both toggle directions.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No findings. The diff looks correct to me on this pass.

Files changed (1) — the diff as I read it

• mobile/src/androidTest/java/net/activitywatch/android/NativeWindowInsetsTest.kt — Adds tapUntilPrefChanges with bounded readiness wait, per-attempt poll, and retry; removes awaitSyncEnabled; updates syncToggleReceivesRealTap to use the new helper.

Previous review passes

commit	score	findings	engine	when
9fce0dd6a30b	3/5	1	llm	2026-09-17 13:24 UTC

_{Reviewed af7425ad7065 · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 41s · about this reviewer}

_{Maintainer commands}

_{@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.}

[TimeToBuildBob]

@greptileai review

[TimeToBuildBob]

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.