ENH: add trip scheduling choice explicit chunking#1041
Open
m-richards wants to merge 1 commit intoActivitySim:mainfrom
Open
ENH: add trip scheduling choice explicit chunking#1041m-richards wants to merge 1 commit intoActivitySim:mainfrom
m-richards wants to merge 1 commit intoActivitySim:mainfrom
Conversation
m-richards
commented
Mar 10, 2026
| # check that tours with no inbound stops have zero inbound duration | ||
| assert out_tours[tsc.IB_DURATION].mask(in_tours[tsc.HAS_IB_STOPS], 0).sum() == 0 | ||
|
|
||
| # confirm explicit chunking is supported and doesn't affect results |
Author
There was a problem hiding this comment.
I can convert this to a parametrised test in the same way as test_agg_accessibility_orig_land_use, I'm not sure if that's preferred or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1040
Based on discussion in #1040 - this model is still being used in the DTP activitysim implementation and with certain other tweaks on their activitysim fork, this step will out of memory on 128GB hardware.
This is pretty simple to wire up. I've added a basic test which shows the parameter is accepted (but it would also pass if I hadn't wired up chunk.adaptive_chunked_choosers, so it's not ideal)
I'm not quite sure what the testing philosophy is at the moment - I've read #1038 and the google doc, not exactly sure what's pragmatic with a small change like this - given there aren't a host of other tests testing for explicit chunking.