fix(android): restore Chinese IME input - #2862
Conversation
github-actions
Bot
added
the
translations
Greptile SummaryThis PR moves the Android Java modification hook after Cordova preparation, changes the aggressive keyboard mode to avoid the password-like input variation, and adds Lingala localization.
Confidence Score: 3/5This PR is not safe to merge until the generated Java method is removed without corrupting nested blocks and the Lingala catalog retains the canonical lookup keys. The method-removal regex can break Android builds in realistically upgraded workspaces, while the translated Lingala keys cause pending-purchase messages to resolve to undefined. Files Needing Attention: hooks/modify-java-files.js, src/lang/ln-ln.json Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Cordova prepare] --> B[after_prepare hook]
B --> C[Load generated SystemWebView.java]
C --> D{Existing patched input method?}
D -->|Yes| E[Regex removes only first nested block]
E --> F[Invalid Java / Android build failure]
D -->|No| G[Continue Java modifications]
G --> H[Android compile]
Reviews (1): Last reviewed commit: "fix(android): restore Chinese IME input" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const regex = new RegExp( | ||
| `\\n\\s*@Override\\s*\\n\\s*public\\s+[^\\s]+\\s+${methodName}\\s*\\([^)]*\\)\\s*\\{[^]*?\\n\\s*\\}`, | ||
| 'm', | ||
| ); |
There was a problem hiding this comment.
When upgrading an Android platform previously patched by version 2, this regex processes an onCreateInputConnection method containing nested if blocks. Its lazy match stops at the first inner closing brace, leaving the else if, else, and return statements behind. This produces invalid SystemWebView.java source and causes the Android build to fail during formatting or compilation.
| "Kosomba ezali kozela": "Kosomba ezali kozela", | ||
| "Ebengami": "Ebengami", |
There was a problem hiding this comment.
These entries translate the lookup keys instead of only their values. The purchase handler requests strings["purchase pending"], but this catalog defines "Kosomba ezali kozela", so a pending purchase under the Lingala locale passes undefined to the error UI. The adjacent entry similarly replaces the canonical "cancelled" key and cannot be resolved by normal localization lookups.
| "Kosomba ezali kozela": "Kosomba ezali kozela", | |
| "Ebengami": "Ebengami", | |
| "purchase pending": "Kosomba ezali kozela", | |
| "cancelled": "Ebengami", |
There was a problem hiding this comment.
Do not mix my PRs or changes from different branches.
The Lingala translation PR was already merged and must NOT be modified, reverted, cherry-picked, or included in my current PR.
My current PR is "fix/chinese-input-2493" and is only for fixing the Chinese IME issue described in #2493.
Please keep this PR completely independent from the previous Lingala translation work. Remove any unrelated Lingala changes from this PR while preserving all changes related to the Chinese IME fix.
The final PR should contain only the changes necessary to fix #2493.
There was a problem hiding this comment.
Understood. The Lingala work is unrelated to PR #2862 and this review comment should not apply to the Chinese IME fix.
The unrelated changes to remove are:
src/lang/ln-ln.json- The corresponding
src/lang/ln-ln.jsonexclusion in_typos.toml
The Android IME changes to preserve are in config.xml and hooks/modify-java-files.js, including moving the hook to after_prepare, removing TYPE_TEXT_VARIATION_VISIBLE_PASSWORD, and ensuring onCreateInputConnection is applied only once.
There was a problem hiding this comment.
Yes, exactly. Please proceed with those changes.
Keep the Chinese IME fix only in PR #2862. Remove the unrelated Lingala changes from the PR, including the "src/lang/ln-ln.json" changes and its "_typos.toml" exclusion.
Do not modify, revert, or alter the already-merged Lingala translation PR.
Preserve the Android IME changes in "config.xml" and "hooks/modify-java-files.js".
There was a problem hiding this comment.
Understood. The Lingala work is unrelated to PR #2862 and this review comment should not apply to the Chinese IME fix.
The unrelated changes to remove are:
src/lang/ln-ln.json- The corresponding
src/lang/ln-ln.jsonexclusion in_typos.tomlThe Android IME changes to preserve are in
config.xmlandhooks/modify-java-files.js, including moving the hook toafter_prepare, removingTYPE_TEXT_VARIATION_VISIBLE_PASSWORD, and ensuringonCreateInputConnectionis applied only once.
Yes, exactly. Please proceed with those changes.
Keep the Chinese IME fix only in PR #2862. Remove the unrelated Lingala changes from the PR, including the "src/lang/ln-ln.json" changes and its "_typos.toml" exclusion.
Do not modify, revert, or alter the already-merged Lingala translation PR.
Preserve the Android IME changes in "config.xml" and "hooks/modify-java-files.js".
There was a problem hiding this comment.
There was a problem hiding this comment.
Re-review complete. The final diff is not yet limited to the Chinese IME fix: it still contains the unrelated src/lang/ln-ln.json addition and _typos.toml exclusion. I excluded those translation contents from the functional IME review, but they remain scope blockers for this PR.
Findings in the intended Android changes:
- P1 —
onCreateInputConnectionis removed but never re-added (hooks/modify-java-files.js, themethods.filter(...)block). The code callsremoveMethod(newContent, 'onCreateInputConnection'), then filters that same method out ofcontentToAddTo.methods. On a platform previously patched by version 2, patch version 3 therefore leavesSystemWebView.javawithout the override, so neither the no-suggestions flag nor the IME behavior is applied. - P1 — method removal can still corrupt Java (
hooks/modify-java-files.js:480). TheremoveMethodregex uses a non-balanced lazy match and stops at the first nested closing brace insideonCreateInputConnection, leaving the remainingelse,return, and method structure behind. This can make the generated Java fail formatting or compilation.
The intended changes themselves are present: the hook is moved to after_prepare, TYPE_TEXT_VARIATION_VISIBLE_PASSWORD is removed, and TYPE_TEXT_FLAG_NO_SUGGESTIONS is applied with |=. GitHub currently reports the commit status as pending with no checks reported. This PR is not ready for approval until the two hook issues are fixed and the Lingala files are removed from the final diff.
There was a problem hiding this comment.
Re-review complete. The final diff is not yet limited to the Chinese IME fix: it still contains the unrelated
src/lang/ln-ln.jsonaddition and_typos.tomlexclusion. I excluded those translation contents from the functional IME review, but they remain scope blockers for this PR.Findings in the intended Android changes:
- P1 —
onCreateInputConnectionis removed but never re-added (hooks/modify-java-files.js, themethods.filter(...)block). The code callsremoveMethod(newContent, 'onCreateInputConnection'), then filters that same method out ofcontentToAddTo.methods. On a platform previously patched by version 2, patch version 3 therefore leavesSystemWebView.javawithout the override, so neither the no-suggestions flag nor the IME behavior is applied.- P1 — method removal can still corrupt Java (
hooks/modify-java-files.js:480). TheremoveMethodregex uses a non-balanced lazy match and stops at the first nested closing brace insideonCreateInputConnection, leaving the remainingelse,return, and method structure behind. This can make the generated Java fail formatting or compilation.The intended changes themselves are present: the hook is moved to
after_prepare,TYPE_TEXT_VARIATION_VISIBLE_PASSWORDis removed, andTYPE_TEXT_FLAG_NO_SUGGESTIONSis applied with|=. GitHub currently reports the commit status as pending with no checks reported. This PR is not ready for approval until the two hook issues are fixed and the Lingala files are removed from the final diff.
Please fix all three blockers before the next review:
-
Remove "src/lang/ln-ln.json" completely from PR fix(android): restore Chinese IME input #2862 and remove its corresponding exclusion from "_typos.toml". Do not modify or revert the already-merged Lingala translation.
-
Fix "hooks/modify-java-files.js" so "onCreateInputConnection" is actually re-added after being removed/replaced. The current "methods.filter(...)" logic removes it but never adds the corrected method back. Make sure the generated "SystemWebView.java" contains exactly one correct "onCreateInputConnection" override.
-
Fix "removeMethod()" so it correctly removes a Java method with nested braces. The current lazy regex stops at the first nested "}", which can leave broken Java code behind. Use balanced-brace parsing or another safe method-removal approach instead of the current non-balanced regex.
After making the fixes, verify that:
- "TYPE_TEXT_VARIATION_VISIBLE_PASSWORD" is absent.
- "TYPE_TEXT_FLAG_NO_SUGGESTIONS" is applied with "|=".
- "onCreateInputConnection" exists exactly once.
- "npx cordova build android" succeeds.
- The final PR diff contains no Lingala translation changes or unrelated "_typos.toml" changes.
Then rerun the review/checks for PR #2862.
Degrace15
left a comment
Degrace15
left a comment
There was a problem hiding this comment.
Before the next review, please clean up PR #2862 completely.
For every modified file, check whether the change is directly related to the Chinese IME fix for issue #2493. If a file contains changes that are not related to this PR, remove those unrelated changes from the PR.
Do not keep unrelated modifications just because they are in the current diff.
The final PR must contain only the changes necessary for the Chinese IME fix. Do not modify or revert the already-merged Lingala translation work.
|
I see 14 commits in PR #2862, but this PR should only contain the 2 commits related to issue #2493. Please clean up the branch history so that the PR contains only the 2 commits that are directly related to the Chinese IME fix. Remove/rebase any unrelated commits from this PR. Do not modify, revert, or include the already-merged Lingala translation work. After cleaning the history, verify that the final PR contains only the changes necessary for issue #2493. |
|
@Degrace15 Hey, Just for your information, Greptile is just a Review Agent, Its not intended for this, and will only lead to errors and worse reviews in return if its context fills up for such tasks. Thanks, |
Thanks for the clarification, UG. Understood. I’ll use Greptile only for reviewing the changes, not for cleaning up or restructuring the PR history. I’ll handle the commit and scope cleanup separately so the PR contains only the changes related to issue #2493. Thanks for pointing that out. |
a44b7ce to
d49ea10
Compare
2 participants
Description
Fixes #2493.
Chinese IME input was not working correctly on Android.
The issue was caused by the aggressive keyboard input configuration using
TYPE_TEXT_VARIATION_VISIBLE_PASSWORD, which interfered with IME composition.This change:
TYPE_TEXT_FLAG_NO_SUGGESTIONS;Testing
npx cordova build android.TYPE_TEXT_VARIATION_VISIBLE_PASSWORDis no longer present.onCreateInputConnectionis present only once.