Fix: remove keyboard animations#2162
Conversation
Greptile SummaryThis PR removes the
Confidence Score: 4/5The change is safe to merge — it intentionally trades smooth keyboard animation for an immediate layout jump, which is the stated goal. The logic reduction is straightforward and correct: the single listener path was already present in the old code for the non-animation case, so the only behavioural change is that intermediate inset frames are no longer applied. The only defect is a missing trailing newline at EOF. No files require special attention beyond the missing EOF newline in SoftInputAssist.java. Important Files Changed
Sequence DiagramsequenceDiagram
participant System as Android System
participant Listener as OnApplyWindowInsetsListener
participant View as contentView
Note over System,View: NEW behaviour (this PR)
System->>Listener: dispatchApplyWindowInsets(finalInsets)
Listener->>Listener: compute keyboardHeight
Listener->>View: setPadding(0, 0, 0, keyboardHeight)
Note over System,View: OLD behaviour (removed)
System->>Listener: dispatchApplyWindowInsets(finalInsets)
alt "animationRunning == false"
Listener->>View: setPadding(0, 0, 0, keyboardHeight)
end
System->>AnimCB: "onPrepare() → animationRunning = true"
loop each animation frame
System->>AnimCB: onProgress(intermediateInsets)
AnimCB->>View: setPadding(left, top, right, intermediateHeight)
end
System->>AnimCB: "onEnd() → animationRunning = false"
Reviews (1): Last reviewed commit: "Merge branch 'Acode-Foundation:main' int..." | Re-trigger Greptile |
No description provided.