Secrets plugin api

[RohitKushvaha01]

Closes #1791

[greptile-apps]

Greptile Summary

Adds encrypted secrets storage API to the plugin system, allowing plugins to securely store and retrieve sensitive data.

• Introduced get_secret and set_secret actions in Java that use EncryptedPreferenceManager for secure storage
• Added corresponding getSecret() and setSecret() methods in JavaScript API
• Properly validates plugin tokens before allowing access to secrets
• Each plugin's secrets are isolated using the plugin ID as the preference namespace

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• Clean implementation following existing patterns, with proper token validation and secure encrypted storage. The getPluginIdFromToken reverse lookup has O(n) complexity but is acceptable for typical plugin counts.
• No files require special attention

Important Files Changed

Filename	Overview
src/plugins/pluginContext/src/android/Tee.java	Adds encrypted secret storage with get_secret and set_secret actions, using token validation and EncryptedPreferenceManager for secure storage
src/plugins/pluginContext/www/PluginContext.js	Adds getSecret and setSecret methods that call the Java secrets API, following existing method patterns

Sequence Diagram

sequenceDiagram
    participant Plugin as Plugin (JS)
    participant PC as PluginContext.js
    participant Tee as Tee.java
    participant EPM as EncryptedPreferenceManager
    
    Plugin->>PC: getSecret(key, defaultValue)
    PC->>Tee: exec("get_secret", [uuid, key, defaultValue])
    Tee->>Tee: getPluginIdFromToken(uuid)
    alt token invalid
        Tee-->>PC: error("INVALID_TOKEN")
    else token valid
        Tee->>EPM: new EncryptedPreferenceManager(context, pluginId)
        Tee->>EPM: getString(key, defaultValue)
        EPM-->>Tee: encrypted value
        Tee-->>PC: success(value)
    end
    PC-->>Plugin: resolve(value)
    
    Plugin->>PC: setSecret(key, value)
    PC->>Tee: exec("set_secret", [uuid, key, value])
    Tee->>Tee: getPluginIdFromToken(uuid)
    alt token invalid
        Tee-->>PC: error("INVALID_TOKEN")
    else token valid
        Tee->>EPM: new EncryptedPreferenceManager(context, pluginId)
        Tee->>EPM: setString(key, value)
        EPM-->>Tee: success
        Tee-->>PC: success()
    end
    PC-->>Plugin: resolve()

Loading

_{Last reviewed commit: 728f743}

[greptile-apps]

_{2 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

[RohitKushvaha01]

@greptileai

[UnschooledGamer]

LGTM