Allow graceful symbol degration to support iOS 15+ at runtime#729
Open
molenick wants to merge 2 commits into
Open
Allow graceful symbol degration to support iOS 15+ at runtime#729molenick wants to merge 2 commits into
molenick wants to merge 2 commits into
Conversation
…upport
Resolves UIAccessibilityPriorityHigh, UIAccessibilityPriorityLow, and
UIAccessibilitySpeechAttributeAnnouncementPriority via dlsym so the adapter no
longer aborts at launch on iOS 15/16. Announcements fall back to a plain,
unprioritized notification when the symbols are absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off - congrats on the release of accesskit_ios! 🎉
I started the process of using accesskit_ios to expose accessibility metadata in my egui app and was getting an immediate runtime crash on iOS 15.8.8. I looked into it and found that a few iOS 17+ symbols were being unconditionally loaded. This work gates the loading of those symbols on iOS 17+ so that iOS 15+ apps can make use of most of accesskit_ios's features.
Testing/Verification
In my private repo I was able to pin accesskit_ios to a local copy of this PR and verify that app was able to build, run and receive accesskit metadata on a real iPhone SE 1st gen running iOS 15.8.8