fix: Optimize removal of unreachable nodes #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcampbell
force-pushed
the
optimize-remove-unreachable
branch
from
9404aad to
869a88b
Compare
DataTriny
approved these changes
Dec 8, 2024
Member
DataTriny
left a comment
DataTriny
left a comment
There was a problem hiding this comment.
Looks good to me. Please rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates an unnecessary step involving temporary storage. I originally wrote that code when I was still quite new to Rust and never revisited the assumption that
to_removewas unnecessary.I also renamed the variable that tracks unreachable nodes and the function that traverses them.