ci: fix broken CI with recent OIIO change and libtiff vs webp - #2160
Open
lgritz wants to merge 1 commit into
Open
ci: fix broken CI with recent OIIO change and libtiff vs webp#2160lgritz wants to merge 1 commit into
lgritz wants to merge 1 commit into
Conversation
The CI "sanitizer" job builds against OIIO main (and has libtiff 4.0.9 pre-installed -- remember that). After recent changes to OIIO main, libtiff 4.1 is the minimum, so it ends up auto-building for OSL's "sanitizer" job. But we specifically try to disable building webp support, so there is a conflict. Don't force disabling of webp building, that takes care of it on this side. Simultaneously fixing the OIIO build to be smarter about it. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
The Mac failure is unrelated. This patch addresses a build failure we were experiencing on the "sanitizer" job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI "sanitizer" job builds against OIIO main. After recent changes to OIIO main, libtiff 4.1 is the minimum, but the GH runner has libtiff 4.0.9 pre-installed, so it ends up auto-building libtiff. But we specifically try to disable building webp support, so there is a conflict when needing the WebP::webp target (which was never built).
Solution: Don't disable webp building.
Simultaneously fixing the OIIO build to be smarter about this as well.