Add documentation for geometry resources - #3029
Conversation
|
|
|
Welcome, @redartengineer, and thanks for this contribution! From an initial review, most of these details look accurate to me, though I'd note a few areas for improvement:
A few smaller notes:
Overall this looks like a great first contribution, and with a few refinements it should be ready to merge. |
|
@jstone-lucasfilm Thanks for the feedback! I've updated the README with the provided feedback by including the intended credits and contributors. I also added additional information for the other geometries. |
|
Thanks for the updates, @redartengineer! The new credits and PR links look great, and the README is very close to ready. Two corrections that I'd consider important before we merge:
Two optional refinements, which you're welcome to include or leave for follow-up:
Does that sound reasonable to you? |
|
@jstone-lucasfilm No problem, I will apply the new feedback! |
Adds a README to the Geometry resources folder documenting the sphere, cube, Shader Ball, and Boombox as well as Chess Set, Cloth, Plane, and Teapot.
Referencing #2343.