-
Notifications
You must be signed in to change notification settings - Fork 1
Adopt a JaCoCo Method Filter extension #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5d1d187
Adopt a JaCoCo Method Filter extension
tmikula-dev 12d2fca
Updating the sbt version for the project
tmikula-dev b3c9a85
Fixing the CI JaCoCo
tmikula-dev d650727
Setting the scala to new version
tmikula-dev bfe3efb
Fixing the path for the jacoco.xml.
tmikula-dev 98c4144
Updating project scala version.
tmikula-dev 2a43d0b
Review comments implementation.
tmikula-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,47 @@ | ||
| name: JaCoCo Report | ||
| name: CI Check JaCoCo | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
| types: [ opened, edited, synchronize, reopened ] | ||
|
|
||
| env: | ||
| scalaLong: 2.13.11 | ||
| scalaLong: 2.13.13 | ||
| scalaShort: "2.13" | ||
| coverage-overall: 80.0 | ||
| coverage-changed-files: 80.0 | ||
| coverage-per-changed-file: 0.0 | ||
|
tmikula-dev marked this conversation as resolved.
|
||
| check-overall-coverages: true | ||
|
|
||
| jobs: | ||
| jacoco-report: | ||
| name: JaCoCo Report | ||
| detect: | ||
| name: Detect Changed Files | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 2 | ||
| outputs: | ||
| scala_changed: ${{ steps.filter.outputs.scala }} | ||
| steps: | ||
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 | ||
| with: | ||
| persist-credentials: false | ||
| fetch-depth: 0 | ||
| - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d | ||
| id: filter | ||
| with: | ||
| token: "" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an optimization, where it does a fallback to do a local comparison and do not run a gh api, when it is not needed. |
||
| filters: | | ||
| scala: | ||
| - '**/*.scala' | ||
| - '!project/**' | ||
|
|
||
| build-test-and-measure: | ||
| name: Build, Test and Measure | ||
| needs: detect | ||
| if: needs.detect.outputs.scala_changed == 'true' | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| issues: write | ||
| pull-requests: write | ||
| services: | ||
| dynamodb-local: | ||
| image: "amazon/dynamodb-local:latest" | ||
|
|
@@ -51,16 +76,22 @@ jobs: | |
| with: | ||
| python-version: '3.14' | ||
|
|
||
| - name: Publish JaCoCo Report in PR comments | ||
| - name: Check coverage thresholds and add reports in PR comments | ||
| id: jacoco | ||
| uses: MoranaApps/jacoco-report@69351d88d18f7697c416e1bc2020ed05606d8120 | ||
| with: | ||
| token: '${{ secrets.GITHUB_TOKEN }}' | ||
| paths: | | ||
| **/target/**/jacoco/report/jacoco.xml | ||
| sensitivity: "detail" | ||
| comment-mode: 'single' | ||
| min-coverage-overall: ${{ env.coverage-overall }} | ||
| min-coverage-changed-files: ${{ env.coverage-changed-files }} | ||
| min-coverage-per-changed-file: ${{ env.coverage-per-changed-file }} | ||
| skip-unchanged: false | ||
| **/target/**/jacoco-report/jacoco.xml | ||
| global-thresholds: '${{ env.coverage-overall }}*${{ env.coverage-changed-files }}' | ||
| report-thresholds-default: '${{ env.coverage-overall }}*${{ env.coverage-changed-files }}*${{ env.coverage-per-changed-file }}' | ||
| comment-level: 'full' | ||
| skip-unchanged: true | ||
|
|
||
| noop: | ||
| name: No Operation | ||
| needs: detect | ||
| if: needs.detect.outputs.scala_changed != 'true' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: echo "No changes in src/**/*.scala — passing." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.