Dockerfile fixed to include .crt files as well#144
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Dockerfile's certificate import step now processes both Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile`:
- Around line 32-33: Fix the typo and make the loop robust: replace the
backticked ls line "for FILE in `ls /opt/certs/*.pem /opt/certs/*.crf`;" with a
glob-based loop over .pem and .crt files (e.g. "for FILE in /opt/certs/*.pem
/opt/certs/*.crt; do [ -f \"$FILE\" ] && cat \"$FILE\" >>
/etc/pki/tls/certs/ca-bundle.crt; done && \") so you correct .crf → .crt and
avoid failing the Docker build when no matches exist by checking [ -f "$FILE" ]
before concatenating.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
oto-macenauer-absa
left a comment
There was a problem hiding this comment.
fix the typo in the file extension also wget needs to be provided with the cert bundle otherwise it will fail:
e.g.
wget --ca-certificate=/etc/pki/tls/certs/ca-bundle.crt https://github.com/edenhill/librdkafka/archive/v2.4.0.tar.gz && \
Co-authored-by: Copilot <copilot@github.com>
Dockerfile fix to include .crt certificate extension.
Release Notes
for FILE inls /opt/certs/.pem /opt/certs/.crf;Related
Closes #143
Summary by CodeRabbit