Convert the inner arrays of a nested constant array literal too - #332
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#330 rebuilds a constant array literal element by element when the element type has to change, but skipped a literal whose elements are arrays. Such a literal keeps
s32inside its inner arrays:The union case failed module verification:
Flat literals (#330), and nested literals of floats or strings — where no element type changes — were already fine.
Fix
castConstArrayToArrayturns a nested element back into a constant array and casts it in turn, so every level is rebuilt.canWideTypeWithoutDataLosscompares the element type inside nested array elements, through the newcanWideConstArrayElementWithoutDataLoss, and only for a constant array source. This is whatcastToTaggedUnionTypeasks when it looks for the union member to cast to; without it no member matched and a cast from the literal straight to the union survived into verification. An array that is not a literal is still not converted element-wise, as before.Tests
New
00const_array_nested_elements.ts(compile, JIT and corpus variants): a nested const variable (outer and inner length, inner element, and that elements really arenumber), a nested literal assigned to anumber[][] | stringunion, and a three-level literal.Full Windows debug suite (
ctest -R "^test-|^unittest-"): 2765/2765 passed.🤖 Generated with Claude Code