FileSystem: clean-up the ffind wrapper - #177
Open
VladimirUmek wants to merge 2 commits into
Open
Conversation
VladimirUmek
commented
Sep 3, 2026
VladimirUmek
commented
Collaborator
- moves search path/pattern processing and comparison to corresponding EFS/FAT module
- moves search path/pattern processing and comparison to corresponding EFS/FAT module
There was a problem hiding this comment.
🟡 Changes recommended
Input validation now returns incorrect statuses for empty or directory-only patterns.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Moves ffind pattern processing into FAT/EFS implementations.
Changes:
- Delegates matching to filesystem-specific modules.
- Adds EFS/FAT wildcard filtering.
- Updates the EFS internal signature and stub.
File summaries
| File | Description |
|---|---|
fs_mapi.c |
Simplifies dispatch logic. |
fs_fat.c |
Adds FAT-side pattern matching. |
fs_efs.c |
Adds EFS-side pattern matching. |
fs_core_lib.h |
Updates the EFS declaration. |
fs_config.c |
Updates the disabled-EFS stub. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.