Skip to content

- Add initial support for ARMv8A, ARMV7R and ARMV8R#45

Open
Masmiseim36 wants to merge 1 commit intoARM-software:mainfrom
Masmiseim36:feature/AddInitialARMv8AandARMv7Rsupport
Open

- Add initial support for ARMv8A, ARMV7R and ARMV8R#45
Masmiseim36 wants to merge 1 commit intoARM-software:mainfrom
Masmiseim36:feature/AddInitialARMv8AandARMv7Rsupport

Conversation

@Masmiseim36
Copy link
Contributor

@Masmiseim36 Masmiseim36 commented Aug 12, 2023

  • Added core_cxx.h files for ARMv8A, ARMV7R and ARMV8R based profiles
  • Moved gic peripheral to separate file
  • Moved __FPU_Enable function to the architecture specific file

@github-actions
Copy link

github-actions bot commented Aug 12, 2023 •
edited
Loading

Test Results

   264 files   -   108     264 suites   - 108   0s ⏱️ - 8m 47s
    56 tests +    7      54 ✅ + 10      2 💤  -     3  0 ❌ ±0 
14 292 runs   - 3 936  12 124 ✅ +160  2 168 💤  - 4 096  0 ❌ ±0 

Results for commit b77b700. ± Comparison against base commit d01c3e6.

This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both. 
CMSIS-Core.src ‑ apsr.c
CMSIS-Core.src ‑ basepri.c
CMSIS-Core.src ‑ bkpt.c
CMSIS-Core.src ‑ clrex.c
CMSIS-Core.src ‑ clz.c
CMSIS-Core.src ‑ control.c
CMSIS-Core.src ‑ cp15.c
CMSIS-Core.src ‑ cpsr.c
CMSIS-Core.src ‑ dmb.c
CMSIS-Core.src ‑ dsb.c
…

TC_CML1Cache_CleanDCacheByAddrWhileDisabled
TC_CML1Cache_EnDisableDCache
TC_CML1Cache_EnDisableICache
TC_CoreFunc_APSR
TC_CoreFunc_BASEPRI
TC_CoreFunc_Control
TC_CoreFunc_EnDisIRQ
TC_CoreFunc_EncDecIRQPrio
TC_CoreFunc_FAULTMASK
TC_CoreFunc_FPSCR
…
This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both. 
CMSIS-Core.src ‑ lda.c
CMSIS-Core.src ‑ ldaex.c
CMSIS-Core.src ‑ stl.c
CMSIS-Core.src ‑ stlex.c
CMSIS-Core.src ‑ systick.c

TC_CoreInstr_WFE
TC_CoreInstr_WFI

♻️ This comment has been updated with latest results.

@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 8da3caa to 396c99a Compare August 21, 2023 16:48
@Masmiseim36 Masmiseim36 mentioned this pull request Sep 29, 2023
Closed
@JonatanAntoni JonatanAntoni requested a review from a user October 17, 2023 06:44
@JonatanAntoni
Copy link
Member

JonatanAntoni commented Oct 17, 2023

@Masmiseim36, could you please update this one with latest cleanups @GuentherMartin is working on, see PR #56.

ghost
ghost reviewed Oct 17, 2023
View reviewed changes
ghost
ghost reviewed Oct 17, 2023
View reviewed changes
ghost
ghost reviewed Oct 17, 2023
View reviewed changes
ghost
ghost reviewed Oct 17, 2023
View reviewed changes
ghost
ghost reviewed Oct 17, 2023
View reviewed changes
ghost
ghost suggested changes Oct 17, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the CMSIS compiler include files missing in r-profile?

@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 396c99a to 924de88 Compare October 22, 2023 16:04
@Masmiseim36
Copy link
Contributor Author

Masmiseim36 commented Oct 22, 2023

are the CMSIS compiler include files missing in r-profile?

They come with this pull Request #44. That PR should be merged first
It makes it a bit difficult to break-up the changes in small chunks. I did the testing with the complete change than break it up again to have smaller Pull-Requests

@JonatanAntoni
Copy link
Member

JonatanAntoni commented Oct 23, 2023

See PR #58 fixing the tests.

@JonatanAntoni JonatanAntoni force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 924de88 to 4961d52 Compare October 23, 2023 10:00
@JonatanAntoni JonatanAntoni reopened this Oct 24, 2023
@JonatanAntoni JonatanAntoni force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch 2 times, most recently from bc0287b to ce515d6 Compare October 25, 2023 16:43
@JonatanAntoni JonatanAntoni mentioned this pull request Oct 26, 2023
Closed
@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from ce515d6 to f66607e Compare October 27, 2023 20:58
@christophe0606 christophe0606 mentioned this pull request Nov 14, 2023
Closed
@JonatanAntoni JonatanAntoni force-pushed the main branch 2 times, most recently from 1b0f516 to d760a27 Compare December 20, 2023 11:59
@JonatanAntoni JonatanAntoni added the enhancement New feature or request label Jan 19, 2024
@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from f66607e to dd2c27b Compare January 28, 2024 16:47
@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch 3 times, most recently from 00ed1eb to 7f7aae9 Compare February 26, 2024 19:26
JonatanAntoni
JonatanAntoni reviewed May 6, 2024
View reviewed changes
@JonatanAntoni JonatanAntoni mentioned this pull request May 6, 2024
Closed
@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch 2 times, most recently from 8d2bcd8 to 4f98c7f Compare May 7, 2024 17:05
@Masmiseim36
Copy link
Contributor Author

Masmiseim36 commented May 7, 2024

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 4f98c7f to 75f40ab Compare May 7, 2024 19:25
@JonatanAntoni
Copy link
Member

JonatanAntoni commented May 8, 2024

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

@JonatanAntoni JonatanAntoni force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 75f40ab to 432826e Compare May 13, 2024 13:03
JonatanAntoni
JonatanAntoni requested changes May 13, 2024
View reviewed changes
@JonatanAntoni
Copy link
Member

JonatanAntoni commented May 13, 2024

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

The updated schema is now available at

https://raw.githubusercontent.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/v1.7.37/schema/PACK.xsd

@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 432826e to 9a7d696 Compare May 13, 2024 18:46
@Masmiseim36
Copy link
Contributor Author

Masmiseim36 commented May 13, 2024

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

Any plans for 0.11.2 release?

@JonatanAntoni
Copy link
Member

JonatanAntoni commented May 14, 2024

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

Any plans for 0.11.2 release?

What 0.11.2 release? The above PR to the pack schema has been merged and published via the schema version 1.3.37 tag.

Please update the schema reference in pdsc file at
https://github.com/ARM-software/CMSIS_6/pull/45/files#diff-2f515e4f53b33d558f9d7ef1cea041f96465055739878ea684a6f19dae2f84efR3

@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 9a7d696 to 780e513 Compare May 14, 2024 20:15
@Masmiseim36
Copy link
Contributor Author

Masmiseim36 commented May 14, 2024

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

Any plans for 0.11.2 release?

What 0.11.2 release? The above PR to the pack schema has been merged and published via the schema version 1.3.37 tag.

Please update the schema reference in pdsc file at https://github.com/ARM-software/CMSIS_6/pull/45/files#diff-2f515e4f53b33d558f9d7ef1cea041f96465055739878ea684a6f19dae2f84efR3

I have mixed the gen-pack version with the pack-spec version. Sorry for that

@Masmiseim36 Masmiseim36 requested a review from JonatanAntoni May 14, 2024 20:47
@JonatanAntoni JonatanAntoni requested a review from a user May 15, 2024 06:14
@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 780e513 to a85823e Compare May 20, 2024 19:41
@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from a85823e to c3c2a87 Compare May 31, 2024 18:22
JonatanAntoni
JonatanAntoni requested changes Jun 3, 2024
View reviewed changes
ARM.CMSIS.pdsc Outdated
</condition>
<condition id="ARMv7-A Device">
<description>Armv7-A architecture based device</description>
<description>Armv7-A and Armv8-A architecture based device</description>
Copy link
Member

@JonatanAntoni JonatanAntoni Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is misleading.

ARM.CMSIS.pdsc Outdated
<accept Dcore="Cortex-A57"/>
</condition>
<condition id="ARMv7_8-A Device">
<description>Armv7_8-A architecture based device</description>
Copy link
Member

@JonatanAntoni JonatanAntoni Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the description from above belongs in here.

@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from c3c2a87 to c8867bc Compare June 3, 2024 18:41
@JonatanAntoni JonatanAntoni force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from c8867bc to 5ac68b5 Compare June 24, 2024 14:20
@JonatanAntoni
Copy link
Member

JonatanAntoni commented Nov 12, 2025

Hi @Masmiseim36,

I think this PR won't receive much more features by now.
Do you still want to get it merged? If yes, could you check rebasing it to latest main then we could integrate it for upcoming CMSIS 6.3.0 release.

@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch 2 times, most recently from c8867bc to 5941eea Compare January 4, 2026 20:20
@Masmiseim36
- Add initial support for ARMv8A, ARMV7R and ARMV8R
b77b700 
- Added core_cxx.h files for ARMv8A, ARMV7R and ARMV8R based profiles
- Moved gic peripheral to separate file
- Moved __FPU_Enable function to the architecture specific file
- Extend core-test routines for new supported core-types
@Masmiseim36 Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 5941eea to b77b700 Compare January 4, 2026 21:37
@smmasongt smmasongt mentioned this pull request Feb 10, 2026
Merged
JonatanAntoni pushed a commit that referenced this pull request Feb 11, 2026
@smmasongt
TI Arm Clang Compiler Support (#276)
6ad4ecb 
Addresses [Issue
#180](#180) and [Issue
#207](#207) which cause
build failures with TI Arm Clang Compiler.

1. It was suggested to move to the generic "cmsis_clang.h" header, which
I agree would be the best long term option. Verified TI Arm Clang
Compiler supports ACLE 2.00 in documentation [1] which should help
reduce the number of specialized handlers for the compiler. Kept a
separate section in "cmsis_compiler.h" for TI Arm Clang Compiler in case
it is needed in the future, and added additional checks so preprocessor
logic is not order dependent.

2. Removed now unused header "cmsis_tiarmclang_m.h".

3. Removed legacy TI Arm Compiler (armcl) section as header
"cmsis_ccs.h" is not present in CMSIS_6.

Tested updates alongside pull request
[#45](#45) on a subset of
CMSIS-DSP functions which was the primary motivation for enabling TI
compiler support.

Test Environment:
TI AM2434, Cortex-R5F, VFPv3-D16
TI CCS 20.4.1.4
TI Arm Clang Compiler v5.0

References:
[1] [TI Arm Clang
Compiler](https://software-dl.ti.com/codegen/docs/tiarmclang/rel5_0_0_STS/)
@smmasongt smmasongt mentioned this pull request Feb 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonatanAntoni JonatanAntoni JonatanAntoni requested changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Masmiseim36 @JonatanAntoni