Fix email icon on landing page to open mail client#561
Fix email icon on landing page to open mail client#561prashantkumarniraj wants to merge 4 commits intoAOSSIE-Org:mainfrom
Conversation
|
@prashantkumarniraj is attempting to deploy a commit to the AOSSIE Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis PR updates UI components to fix email link responsiveness issues and standardize icon usage. Changes include replacing Next.js Link components with standard anchor tags for mailto links across the Footer and index pages, updating the Twitter icon from faTwitter to faXTwitter, and simplifying responsive typography breakpoints in the about page. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/index.jsx (1)
9-14:⚠️ Potential issue | 🔴 Critical
faXTwitteris not available in@fortawesome/free-brands-svg-iconsv6.2.1 — upgrade the package to v6.4.2+ or revert tofaTwitter.The project uses v6.2.1, but
faXTwitterwas only introduced in v6.4.2. Importing a non-existent icon will cause builds to fail.This also applies to: 91-95
This PR fixes an issue where the email icon on the landing page did not open
the user’s mail client when clicked.
The icon was previously wrapped in the Next.js
Linkcomponent using amailto:URL, which caused the router to intercept the click and prevent thebrowser from handling the mail protocol correctly.
This change replaces the framework-specific
Linkwith a standard HTMLanchor tag, allowing the browser to handle the
mailto:link as expected.No visual or styling changes were introduced.
Fixes #560
Summary by CodeRabbit