Convert a memory into an album, plus album sorting and grid updates - #1456
Conversation
Adds a three-dot menu to the memory grid tiles, matching the album cards, with a Convert to Album action. POST /albums/from-memory copies the memory's photos into a new album in one transaction; the memory is left untouched and clips are skipped, since albums hold images only.
The album and memory tiles already grow as the window widens, but the actions menu and the lock badge were a fixed size, so they looked heavy on a small window. They now step at lg and xl alongside the grid, and keep their current size at xl. Icons switch to size-* because the button variant forces size-4 onto any svg without a size- class, which silently overrode the old h-5 w-5.
This reverts commit c995372.
Both grids stepped their column count at breakpoints, so every card resized as the window changed. They now use the same auto-fill grid the chronological and ranked galleries use: cards hold a near-constant width and the column count follows the window instead. The class string was already repeated across the three galleries, so it moves to a constant they all share.
Adds created_at and updated_at to albums, both migrated onto existing databases. created_at is written once and never touched again; updated_at moves on a rename, a description or lock change, and on photos being added or removed, since to a user that is the album changing. Albums predating the columns have no timestamps rather than fabricated ones. They read as oldest, and the listing now orders by rowid so their fallback order is the order they were made in. The sort choice also survives a reload now, stored per surface in localStorage like the theme. AI Tagging gets it from the same hook: it uses the same dropdown and reset the same way.
|
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAlbum storage now tracks lifecycle timestamps and supports transactional creation from memory photos. The frontend adds conversion controls, typed API access, persisted sorting, timestamp-based album ordering, and shared media-grid styling. Tests and OpenAPI documentation cover the new behavior. ChangesAlbum enhancements
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant MemoryCard
participant ConvertMemoryToAlbumDialog
participant createAlbumFromMemory
participant albums_endpoint
participant album_util_create_from_memory
MemoryCard->>ConvertMemoryToAlbumDialog: choose Convert to Album
ConvertMemoryToAlbumDialog->>createAlbumFromMemory: submit memory_id and album name
createAlbumFromMemory->>albums_endpoint: POST /albums/from-memory
albums_endpoint->>album_util_create_from_memory: validate memory and create album
album_util_create_from_memory-->>albums_endpoint: return album ID and image count
albums_endpoint-->>ConvertMemoryToAlbumDialog: return creation result
Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
backend/app/database/albums.py (1)
304-308: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winUpdate
updated_atonly after an album-image row changes.Both operations can affect zero rows but still call
_touch_album. This records a false album update and changes update-date sorting.
backend/app/database/albums.py#L304-L308: call_touch_albumonly whenINSERT OR IGNOREinserts at least one row.backend/app/database/albums.py#L336-L340: call_touch_albumonly when the bulk deletion removes at least one row.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/app/database/albums.py` around lines 304 - 308, In backend/app/database/albums.py lines 304-308, update the album-image insertion flow to call _touch_album only when cursor.executemany inserts at least one row, using the database row-change result. Apply the same conditional behavior to the bulk deletion flow at lines 336-340, calling _touch_album only when at least one row is removed.
🧹 Nitpick comments (1)
backend/tests/test_albums.py (1)
602-612: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winVerify that the persisted album ID matches the response ID.
The test validates both values independently but does not compare them. A regression could pass one UUID to
db_create_album_with_imagesand return another UUID to the client.Proposed fix
album_id, name, description, image_ids = mock_create.call_args.args + assert album_id == json_response["data"]["album_id"] assert name == "Paris 2022"As per path instructions, ensure that critical functionality has comprehensive automated tests. <path_instructions>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/tests/test_albums.py` around lines 602 - 612, Update the album creation test around mock_create.call_args.args to capture the persisted album_id and assert it equals json_response["data"]["album_id"], while retaining UUID validation and the existing name, description, and image_ids assertions.Sources: Path instructions, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/app/database/albums.py`:
- Around line 90-101: Define an AlbumRow TypedDict for the eight album columns,
then update db_get_all_albums and the two related database functions to return
AlbumRow records with accurate list return annotations. Map each fetched row by
column name rather than exposing positional tuples, while preserving the
existing query ordering and values.
In `@backend/app/routes/albums.py`:
- Around line 103-104: Complete the route contract on create_album_from_memory
by adding the CreateAlbumFromMemoryResponse return annotation and documenting
400, 404, 409, and 500 responses with ErrorResponse models. Preserve the
existing Pydantic request body signature without adding redundant body metadata.
In `@backend/app/schemas/album.py`:
- Around line 37-39: Update CreateAlbumFromMemoryRequest with a validator that
trims memory_id and name and rejects values that are blank after stripping,
while preserving the normalized values. Add a backend test covering
whitespace-only input for both fields.
In `@frontend/src/components/Memories/ConvertMemoryToAlbumDialog.tsx`:
- Around line 40-45: Update the useEffect that initializes name and error so it
depends on both memory and isOpen, and performs the reset only on an opening
transition while a memory is present. Preserve existing behavior for memory
changes, and add a dialog test covering close/reopen with the same memory
instance to verify stale state is cleared.
In `@frontend/src/hooks/__tests__/usePersistedSort.test.ts`:
- Around line 1-46: Rename the test file containing the usePersistedSort suite
to use the required .test.tsx extension, preserving its contents and test
behavior.
---
Outside diff comments:
In `@backend/app/database/albums.py`:
- Around line 304-308: In backend/app/database/albums.py lines 304-308, update
the album-image insertion flow to call _touch_album only when cursor.executemany
inserts at least one row, using the database row-change result. Apply the same
conditional behavior to the bulk deletion flow at lines 336-340, calling
_touch_album only when at least one row is removed.
---
Nitpick comments:
In `@backend/tests/test_albums.py`:
- Around line 602-612: Update the album creation test around
mock_create.call_args.args to capture the persisted album_id and assert it
equals json_response["data"]["album_id"], while retaining UUID validation and
the existing name, description, and image_ids assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 237f8e0a-89ce-4c84-82f5-9ff3da7f1ac0
📒 Files selected for processing (24)
backend/app/database/albums.pybackend/app/routes/albums.pybackend/app/schemas/album.pybackend/tests/test_albums.pybackend/tests/test_albums_db.pydocs/backend/backend_python/openapi.jsonfrontend/src/api/api-functions/albums.tsfrontend/src/api/apiEndpoints.tsfrontend/src/components/GallerySortDropdown.tsxfrontend/src/components/Media/ChronologicalGallery.tsxfrontend/src/components/Media/ChronologicalVideoGallery.tsxfrontend/src/components/Media/RankedGallery.tsxfrontend/src/components/Memories/ConvertMemoryToAlbumDialog.tsxfrontend/src/components/Memories/MemoryCard.tsxfrontend/src/components/Memories/__tests__/MemoryCard.test.tsxfrontend/src/constants/layout.tsfrontend/src/hooks/__tests__/usePersistedSort.test.tsfrontend/src/hooks/usePersistedSort.tsfrontend/src/pages/AITagging/AITagging.tsxfrontend/src/pages/Album/Album.tsxfrontend/src/pages/Album/AlbumDetail.tsxfrontend/src/pages/Memories/Memories.tsxfrontend/src/pages/__tests__/Album.test.tsxfrontend/src/types/Album.ts
Album reads now return an AlbumRow TypedDict instead of positional tuples, so the routes look columns up by name rather than by index. The from-memory route declares its error responses and return type, and its request rejects names and ids that are blank once trimmed. Adding images that are already in an album, or removing ones that are not, no longer marks the album as updated, matching what the single image removal already did. The convert dialog resets on opening rather than only when the memory changes, so a name typed and abandoned does not come back.
|
|
1 similar comment
|
|
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
backend/app/schemas/album.py (1)
41-48: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAnnotate the validator signature completely.
check_not_blankleavesclsuntyped. Annotateclswith the model class type to meet the backend signature requirement. Confirm that the selected annotation is accepted by the installed Pydantic version.As per coding guidelines, “Annotate function signatures and return types accurately.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/app/schemas/album.py` around lines 41 - 48, Update the check_not_blank validator signature to annotate cls with the enclosing album schema model class, while preserving the existing value and return annotations and validation behavior. Use the class annotation form supported by the installed Pydantic version.Source: Coding guidelines
frontend/src/components/Memories/__tests__/ConvertMemoryToAlbumDialog.test.tsx (1)
10-16: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse a complete typed memory fixture.
as MemoryCardhides missing required fields. Definememoryas a completeMemoryCard, or use a typed fixture factory that returnsMemoryCard.As per coding guidelines, “do not use
asto silence real type errors.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/src/components/Memories/__tests__/ConvertMemoryToAlbumDialog.test.tsx` around lines 10 - 16, Replace the casted memory fixture in ConvertMemoryToAlbumDialog tests with a complete, type-safe MemoryCard object, including every required field, or use an existing typed fixture factory that returns MemoryCard. Remove the `as MemoryCard` assertion while preserving the fixture values needed by the tests.Source: Coding guidelines
backend/tests/test_albums.py (1)
23-34: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winType the album-row fixture.
album_rowaccepts and returns bare dictionaries. Define or reuse aTypedDictfor this database-row shape. Annotate the optional timestamp and cover-path parameters too. This prevents fixture keys from drifting from the database contract.As per coding guidelines, “represent table rows with
TypedDictclasses rather than bare dictionaries.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/tests/test_albums.py` around lines 23 - 34, Update the album_row fixture to use a TypedDict representing the complete album database-row shape, including album_id, album_name, description, is_locked, password_hash, cover_image_path, created_at, and updated_at. Annotate album_row’s album parameter and return type with that TypedDict, and give cover_image_path, created_at, and updated_at explicit optional types consistent with the row contract.Source: Coding guidelines
backend/app/database/albums.py (1)
2-2: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winReplace deprecated
typing.Listandtyping.Tuplealiases.
ruff check --select UP035flags these imports. Usetuple[Any, ...]for_to_album_row(row: ...),list[AlbumRow]fordb_get_all_albums(), and removeListandTuplefrom the import line. The module already has supported runtime annotations for these generics.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/app/database/albums.py` at line 2, Replace deprecated List and Tuple annotations in _to_album_row and db_get_all_albums with built-in generic forms tuple[Any, ...] and list[AlbumRow], respectively, and remove List and Tuple from the typing imports.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/app/database/albums.py`:
- Around line 126-136: Replace the direct sqlite3.connect(DATABASE_PATH) calls
in db_get_all_albums, db_get_album_by_name, and db_get_album with the
module-private _connect() helper, preserving each function’s existing query
logic and finally-based connection cleanup.
In `@backend/tests/test_albums.py`:
- Around line 342-351: Update the password fixtures in album_row to pass byte
literals directly to bcrypt.hashpw, replacing the redundant "oldpass".encode()
and "correctpass".encode() calls with b"oldpass" and b"correctpass".
In `@docs/backend/backend_python/openapi.json`:
- Around line 499-537: The error response schemas for statuses 400, 404, 409,
and 500 currently describe ErrorResponse at the root, but HTTPException
responses wrap it under detail. Update the referenced
app__schemas__album__ErrorResponse schema or these response definitions so the
documented envelope requires a detail property containing success, message, and
error, preserving the existing error payload fields.
---
Nitpick comments:
In `@backend/app/database/albums.py`:
- Line 2: Replace deprecated List and Tuple annotations in _to_album_row and
db_get_all_albums with built-in generic forms tuple[Any, ...] and
list[AlbumRow], respectively, and remove List and Tuple from the typing imports.
In `@backend/app/schemas/album.py`:
- Around line 41-48: Update the check_not_blank validator signature to annotate
cls with the enclosing album schema model class, while preserving the existing
value and return annotations and validation behavior. Use the class annotation
form supported by the installed Pydantic version.
In `@backend/tests/test_albums.py`:
- Around line 23-34: Update the album_row fixture to use a TypedDict
representing the complete album database-row shape, including album_id,
album_name, description, is_locked, password_hash, cover_image_path, created_at,
and updated_at. Annotate album_row’s album parameter and return type with that
TypedDict, and give cover_image_path, created_at, and updated_at explicit
optional types consistent with the row contract.
In
`@frontend/src/components/Memories/__tests__/ConvertMemoryToAlbumDialog.test.tsx`:
- Around line 10-16: Replace the casted memory fixture in
ConvertMemoryToAlbumDialog tests with a complete, type-safe MemoryCard object,
including every required field, or use an existing typed fixture factory that
returns MemoryCard. Remove the `as MemoryCard` assertion while preserving the
fixture values needed by the tests.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 42bc85a9-d1e7-4f4a-8a78-21f00bfcebf0
📒 Files selected for processing (9)
backend/app/database/albums.pybackend/app/routes/albums.pybackend/app/schemas/album.pybackend/tests/test_albums.pybackend/tests/test_albums_db.pydocs/backend/backend_python/openapi.jsonfrontend/src/components/Memories/ConvertMemoryToAlbumDialog.tsxfrontend/src/components/Memories/__tests__/ConvertMemoryToAlbumDialog.test.tsxfrontend/src/hooks/__tests__/usePersistedSort.test.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
- backend/app/routes/albums.py
- frontend/src/components/Memories/ConvertMemoryToAlbumDialog.tsx
All album reads now go through a module-private _connect(), matching the videos module, so the foreign-key pragma is never skipped. The three select statements are built once from the shared column list rather than interpolated at each call site. The from-memory route documents its errors with an envelope model, since HTTPException nests the payload under detail and the generated spec was describing a shape no client receives. Its duplicated conflict and internal-error blocks collapse into two helpers, and the raises inside except blocks now chain the original error.
|
|
1 similar comment
|
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
backend/tests/test_albums.py (1)
23-36: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick winDefine a
TypedDictfor album database rows.
album_rowcreates database row-shaped mappings that route mocks consume. Define anAlbumRow(TypedDict)and annotate the helper input and return value. This prevents fixture keys from drifting from the database-row contract.As per coding guidelines, “In Python, annotate function signatures and return types; represent table rows with
TypedDictclasses rather than bare dictionaries.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/tests/test_albums.py` around lines 23 - 36, Define an AlbumRow TypedDict for the database-row keys returned by album_row, including appropriate value types and nullable fields for cover_image_path, created_at, and updated_at. Update album_row’s album parameter and return annotation to use the relevant typed structures while preserving the existing row contents.Source: Coding guidelines
backend/app/routes/albums.py (1)
115-168: 📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy liftMove the conversion workflow to
app/utils/.The route performs memory lookup, image selection, duplicate detection, and album-creation coordination. Extract this workflow to a utility helper. Keep the route limited to request parsing, response mapping, and HTTP error translation.
As per coding guidelines, “Routes handle HTTP and validation only; business logic belongs in
app/utils/and data access belongs inapp/database/.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/app/routes/albums.py` around lines 115 - 168, The create_album_from_memory route currently contains the full conversion workflow. Extract the memory lookup, image selection, duplicate detection, UUID generation, and album creation coordination into a dedicated helper under app/utils, preserving its existing behavior and database calls; keep create_album_from_memory limited to invoking the helper, mapping its result to CreateAlbumFromMemoryResponse, and translating domain failures into HTTP errors.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@backend/app/routes/albums.py`:
- Around line 115-168: The create_album_from_memory route currently contains the
full conversion workflow. Extract the memory lookup, image selection, duplicate
detection, UUID generation, and album creation coordination into a dedicated
helper under app/utils, preserving its existing behavior and database calls;
keep create_album_from_memory limited to invoking the helper, mapping its result
to CreateAlbumFromMemoryResponse, and translating domain failures into HTTP
errors.
In `@backend/tests/test_albums.py`:
- Around line 23-36: Define an AlbumRow TypedDict for the database-row keys
returned by album_row, including appropriate value types and nullable fields for
cover_image_path, created_at, and updated_at. Update album_row’s album parameter
and return annotation to use the relevant typed structures while preserving the
existing row contents.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ace9df07-982e-4401-b1b8-5ea8edb5bfc2
📒 Files selected for processing (6)
backend/app/database/albums.pybackend/app/routes/albums.pybackend/app/schemas/album.pybackend/tests/test_albums.pydocs/backend/backend_python/openapi.jsonfrontend/src/hooks/usePersistedSort.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- frontend/src/hooks/usePersistedSort.ts
- backend/app/database/albums.py
The route was doing the memory lookup, the image selection, the duplicate-name check and the album creation itself. That work moves to album_util_create_from_memory, which raises a small set of domain errors the route translates into status codes, leaving it to handle HTTP only. Isolating it exposed an untested branch: the insert can still hit the unique constraint after the name check passes, and only a name that is taken on re-check means a conflict. Anything else has to surface rather than be reported as a duplicate. Both paths now have tests. The row helper in the album route tests builds the production AlbumRow instead of a look-alike dict, so a column added to the table fails there rather than drifting.
|
|
1 similar comment
|
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
backend/tests/test_albums.py (1)
565-667: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the required backend test annotations.
backend/tests/test_albums.py#L565-L667: Add exact fixture parameter types and-> Noneto every method inTestCreateAlbumFromMemory.backend/tests/test_album_utils.py#L18-42: Import and useAlbumFromMemoryResultforrun_with_integrity_error, and add-> Noneto both new test methods.Run
pre-commit run --config .pre-commit-config.yaml --all-filesfrom the repository root after updating these annotations.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/tests/test_albums.py` around lines 565 - 667, Update every test method in backend/tests/test_albums.py lines 565-667 within TestCreateAlbumFromMemory to use the exact fixture parameter types and an explicit -> None return annotation. In backend/tests/test_album_utils.py lines 18-42, import and apply AlbumFromMemoryResult as the return type for run_with_integrity_error, and add -> None to both new test methods. Run pre-commit with the repository’s .pre-commit-config.yaml across all files.Sources: Coding guidelines, Path instructions
🧹 Nitpick comments (1)
backend/tests/test_albums.py (1)
9-9: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUse the Python 3.9 built-in generic.
Replace
Dict[str, Any]withdict[str, Any]inalbum_rowand removeDictfromfrom typing import Any, Dict, Optional. KeepOptional[str]because this module does not use postponed annotations.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/tests/test_albums.py` at line 9, Update album_row to use the Python 3.9 built-in generic dict[str, Any] instead of Dict[str, Any], and remove Dict from the typing import while retaining Any and Optional for the module’s existing annotations.Sources: Coding guidelines, Path instructions, Learnings, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/app/utils/albums.py`:
- Around line 7-8: Move the database-orchestration workflow currently
implemented by album_util_create_from_memory from app/utils/albums.py into
app/database/, including its memory/image reads, album-state checks, album
creation, and transaction ownership. Update callers and imports to use the
database-layer function, leaving app/utils/albums.py with only pure
transformations.
---
Outside diff comments:
In `@backend/tests/test_albums.py`:
- Around line 565-667: Update every test method in backend/tests/test_albums.py
lines 565-667 within TestCreateAlbumFromMemory to use the exact fixture
parameter types and an explicit -> None return annotation. In
backend/tests/test_album_utils.py lines 18-42, import and apply
AlbumFromMemoryResult as the return type for run_with_integrity_error, and add
-> None to both new test methods. Run pre-commit with the repository’s
.pre-commit-config.yaml across all files.
---
Nitpick comments:
In `@backend/tests/test_albums.py`:
- Line 9: Update album_row to use the Python 3.9 built-in generic dict[str, Any]
instead of Dict[str, Any], and remove Dict from the typing import while
retaining Any and Optional for the module’s existing annotations.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c3672d01-ff3c-4e23-8576-1b21f93660c1
📒 Files selected for processing (4)
backend/app/routes/albums.pybackend/app/utils/albums.pybackend/tests/test_album_utils.pybackend/tests/test_albums.py
🚧 Files skipped from review as they are similar to previous changes (1)
- backend/app/routes/albums.py
Exact fixture parameter types and return annotations on the conversion tests and the two util tests, and the row helper takes a built-in dict generic.
|
|
1 participant
Memories can now be turned into albums.
Hovering a memory card brings up the same three dot menu the album cards already have, with a Convert to Album action in it.
It opens a small dialog with the name prefilled from the memory title, and drops you on the new album once it is created.
The conversion is a single call to
POST /albums/from-memory, which copies the memory's photos into a new album in one transaction, so a partial failure cannot leave an empty album behind.The memory itself is left alone and can be converted again later under a different name.
Videos are skipped since albums only hold photos, and the dialog says so when the memory has any.
Grid layout
The album and memory grids changed their column count at breakpoints, so every card resized whenever the window did.
They now use the same auto fill grid the chronological and ranked galleries already use, where the cards keep a steady width and only the number of columns follows the window.
That class string was repeated across the three gallery files, so it now lives in a single shared constant.
Album sorting
Albums can be sorted by date created and by recently updated, alongside the existing name and photo count.
This adds two columns to the albums table, both migrated onto existing databases.
created_atis written once when the album is made and is never touched again.updated_atmoves when the album is renamed, when its description or lock changes, and when photos are added or removed.Albums that predate these columns have no timestamps rather than invented ones.
They read as oldest, and the listing now orders by rowid so their fallback order matches the order they were actually created in.
The sort choice also survives a reload now, stored per page in localStorage the same way the theme already is.
The AI Tagging page picks it up through the same hook, since it uses the same dropdown and reset the same way.
Tests
Covers the new endpoint and its failure cases, the timestamp behaviour against a real database including the legacy migration path, the memory card menu, both new sorts, and the persistence hook.
Summary by CodeRabbit
New Features
Bug Fixes