Skip to content

fix: close IndexedDB connections after each cache operation #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranayr710 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: close IndexedDB connections after each cache operation #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/services/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ function openDB() {
export async function cacheGet(key) {
try {
const db = await openDB()
// close() only takes effect once the in-flight transaction below settles,
// so it's safe to call right away instead of leaving the connection open.
const req = db.transaction(STORE, 'readonly').objectStore(STORE).get(key)
db.close()
return new Promise(res => {
const req = db.transaction(STORE, 'readonly').objectStore(STORE).get(key)
req.onsuccess = () => {
const r = req.result
if (!r || Date.now() - r.ts > TTL_MS) return res(null)
Expand All @@ -30,9 +33,10 @@ export async function cacheGet(key) {
export async function cacheSet(key, value) {
try {
const db = await openDB()
const tx = db.transaction(STORE, 'readwrite')
tx.objectStore(STORE).put({ k: key, v: value, ts: Date.now() })
db.close()
return new Promise(res => {
const tx = db.transaction(STORE, 'readwrite')
tx.objectStore(STORE).put({ k: key, v: value, ts: Date.now() })
tx.oncomplete = () => res(true)
tx.onerror = () => res(false)
})
Expand All @@ -42,9 +46,10 @@ export async function cacheSet(key, value) {
export async function cacheClear() {
try {
const db = await openDB()
const tx = db.transaction(STORE, 'readwrite')
tx.objectStore(STORE).clear()
db.close()
return new Promise(res => {
const tx = db.transaction(STORE, 'readwrite')
tx.objectStore(STORE).clear()
tx.oncomplete = () => res(true)
tx.onerror = () => res(false)
})
Expand Down
Loading