fix: improve calendar picker icon visibility in Dark Mode - #149
Conversation
WalkthroughGlobal CSS now styles date input calendar indicators. The indicators use a pointer cursor and filter transition. Dark themes invert the indicator colors. Light themes remove the filter. ChangesDate picker styling
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/styles/global.css`:
- Around line 66-79: Scope the date-picker rules around the shared .date-input
class instead of the global input[type="date"] selector, including the cursor,
transition, and both theme-specific indicator rules in global.css. Add the same
class to both date inputs in ContributorProfilePage.jsx, using the existing
naming convention and preserving the current light/dark behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 518224a3-fd9f-456c-9831-db262ee90857
📒 Files selected for processing (1)
src/styles/global.css
| input[type="date"]::-webkit-calendar-picker-indicator { | ||
| cursor: pointer; | ||
| transition: filter 0.2s ease; | ||
| } | ||
|
|
||
| /* Dark theme */ | ||
| :root:not([data-theme="light"]) input[type="date"]::-webkit-calendar-picker-indicator { | ||
| filter: invert(1); | ||
| } | ||
|
|
||
| /* Light theme */ | ||
| [data-theme="light"] input[type="date"]::-webkit-calendar-picker-indicator { | ||
| filter: none; | ||
| } No newline at end of file |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Scope the date-picker styles to the intended controls.
If only the contributor profile date inputs need this behavior, replace the global input[type="date"] selector with a shared class such as .date-input. The current selector changes every date input in the application and can affect unrelated forms.
Proposed scope change
-input[type="date"]::-webkit-calendar-picker-indicator {
+.date-input::-webkit-calendar-picker-indicator {
cursor: pointer;
transition: filter 0.2s ease;
}
:root:not([data-theme="light"]) input[type="date"]::-webkit-calendar-picker-indicator {
filter: invert(1);
}
[data-theme="light"] input[type="date"]::-webkit-calendar-picker-indicator {
filter: none;
}Apply the same .date-input selector to the two date inputs in src/pages/ContributorProfilePage.jsx.
As per path instructions, review CSS against Google CSS style guidance and use consistent class and ID naming conventions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/styles/global.css` around lines 66 - 79, Scope the date-picker rules
around the shared .date-input class instead of the global input[type="date"]
selector, including the cursor, transition, and both theme-specific indicator
rules in global.css. Add the same class to both date inputs in
ContributorProfilePage.jsx, using the existing naming convention and preserving
the current light/dark behavior.
Source: Path instructions
Link your account with GitcordThanks for opening this PR, @jikrana1! To receive Discord notifications and contributor tracking for this organization:
Once linked, Gitcord can notify you about reviews, merges, and more. — Posted by Gitcord |
Addressed Issues
Fixes #144
Changes
Checklist
Screenshots
Before
Dark Mode
Light Mode
After
Dark Mode
Light Mode
Summary by CodeRabbit