Fix/memory leak #530
Closed
Fix/memory leak #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maximilian Wulf <maximilianwulf@users.noreply.github.com>
Initial ROS2 port
* initial commit * docker image changed Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * removed testing specific packages only * added ros2 branch filter * fixed typo * removed filter and remaned job Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* test * added colcon ignore to grid_map metapackage * removed added space
* Linted and uncrustified * Updated cmakelists and package.xml * Fixed header guard position * fixed build errors * test files now building * ported package.xml * cleaned cmakelists * bumped to 2.0.0 * added EOF new line * removed unnecessary comments * one more unnecessary comment * fixed header comment for EllipseIteratorTest.cpp * updated dep grid_map_common to grid_map_cmake_helpers * removed unused function param in GridMap::getSubmap method * updated grid_map_common to grid_map_cmake_helpers * removed redunent/wrong method defintion and removed unused method definition * refactored switch cases to if conditions * removed grid_map_core colcon ignore * turned on the automatic linter unit tests * linted cmake files * fixed Werror=deprecated-copy in GridMapIterator.cpp * fixed mixed cases linting error * Disabled cpplint legal linting error message Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * suppressing returnTempReference cppcheck in GridMap.cpp * Added note about linting config Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
* Added mising extra cmake config file and exported the include dirs in grid_map_core/CMakeLists.txt * grid_map_cv linted and ported
* Port grid_map_costmap_2d to ros2 Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Rename files to camel case Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Add ros2_dependencies and update circle ci config to build ros2 dependencies Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Fix circle ci config Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Fix test cppcheck error Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
* uncrustify autoformat * port grid_maps_sdf * last bit of linting * remove rosdep for pcl_ros * rename files to hpp * removing indent in namespaces * relinting again * fix mistake * Update grid_map_sdf/src/SignedDistanceField.cpp Co-authored-by: Marwan Taher <marokhaled99@gmail.com> Co-authored-by: Marwan Taher <marokhaled99@gmail.com>
* package.xml and CMakeLists.txt updated. src, include and tests linted * Added octomap as dep and upated CI * updated costmap2d parameter in grid_map_costmap_2d tests * removed unwanted comments * reverted ros2_dependency and circleci config as octomap got released for foxy * ignoring slam_toolbox in rosdep
* Updated CMakelists.txt and package.xml * Ported & linted header, src and test files * undone the OccupancyGrid to Costmap changes * Added conversion to and from Costmap msg * removed typo * Fixed value limits in costmap conversions and updated costmap conversion tests * rosbag section updated * re-triggering CI * adding rcpputils as a dep to use rcpputils::fs::remove_all * Triggering CI * added rosbag2 as a dependency and changed rcpputils dependency to master * fixed typo * added missing macro * fixed comparison of different signs * some reformatting and typos fixed
* linted and uncrustified * updated package.xml and removed COLCON_IGNORE * updated CMakeLists.txt and package.xml Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * updated ros related APIs Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added missing sleep Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * changed publish to use unique_ptr Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * toMessage signature updated Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * updated toMessage, add qos config and some cmake fixes Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * message_traits.hpp ported * fixed message_traits namespace Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * removed QOS custom lifespan Signed-off-by: Marwan Taher <marokhaled99@gmail.com>
* linted and uncrustified * package.xml mostly updated * updated ROS related APIs Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * upadted CMakeLists.txt and package.xml Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * declared missing params and some minor fixes Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * updating navigation2 branch name Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * updating navigation2 dependency file name Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added subscription updating Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * updated isActive method Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * changed nodehandle to node Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * addressing comments - added latching, alphabetical formatting, updating isActive & reverting for loops changes. Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * fixig CI running out of memory * refactored classes to derive from node Signed-off-by: Marwan Taher <marokhaled99@gmail.com>
* linted and uncrustified * updated package.xml and plugin_description.xml, and removed COLCON_IGNORE * ros2 related api updates Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * updated CMakeLists.txt and package.xml Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * bug fixes Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * removed modified include files Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * removed unneeded comments Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * fixed rviz crashing after disabling gridmap display Signed-off-by: Marwan Taher <marokhaled99@gmail.com>
* mostly linted and uncrustified * updated package.xml and filter_plugins.xml * ros2 API updates Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * updated CMakeLists.txt Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added testing section to CMakeLists.txt Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * fixed linting errors Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * using empty() to check for empty vectors Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * minor formatting Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * minor reformatting Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * more reformatting Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * fixed deprecated tbb functions warnings Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * CI fix - building packages sequentially using a different flag * CI fixing attempt * splitting up libraries * CI memory usage fix * CI changing docker image * temporary change to test without octomap as a dep * re-added rcpputils to underlay build * reverted changes and limited underlay building workers * fixed commented param read Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added thread count comment Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added deepcode ignore comment * removed building nav2 - use released binaries instead
* mostly linted and removed COLCON_IGNORE * package.xml mostly updated * ROS2 porting changes Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * Porting launch file to a python script Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added pcl_ros as dep for CI Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * moved test_data install inside if(BUILD_TESTING) Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * adding pcl_msgs to deps Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * CI fix Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * fixed pcd file path for failing test Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * changed tests timeout Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * increased test timeout to 300 Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * addressing comments Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * minor reformatting Co-authored-by: Maximilian Wulf <maximilianwulf@users.noreply.github.com> Co-authored-by: Maximilian Wulf <maximilianwulf@users.noreply.github.com>
* mostly linted and removed COLCON_IGNORE * simple_demo and tutorial_demo port Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * image_to_gridmap_demo and iterators_demo port Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * more linting Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * visualizations fix - using one shared node accross all visualizations instead of a node for each visualization Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * minor fixes and formatting Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * renamed node_ptr to nodePtr and removed unwanted commented code Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * changed grid_map_ros lib to be shared Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added eigen to include dirs
* move_demo ported Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * iterator_benchmark ported Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * opencv_demo ported Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * octomap_to_gridmap_demo port (needs testing) Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * CMakeLists.txt and package.xml updated Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * grid_map_loader_demo ported Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * new ros2 grid_map bag Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * fixed typo Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * minor formatting fixes and added TODO Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * fixed failed grid_map_loader visualization in rviz; transient local option to visualisation gridmap subscriber Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * sleep_for duration minor refactoring Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * changed octomap published msg to unique_ptr * updated readme - build instructions, running demos, ros testing version, octomap demo note and msgs Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added missing building step * fixed dep building instructions * throttled client wait logging and introduces 'using' for octomap msg and srv namespaces Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * added comments to launch files Signed-off-by: Marwan Taher <marokhaled99@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Add Ryan as maintainer, remove Steve
…r-filters Bugfix use old style include directories for filters
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
…ostmap-2d Use ament_export_targets in grid_map_costmap_2d
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
…server build: treat several build issues on rolling
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
…on (ANYbotics#438) (ANYbotics#468) Fix LoadFromBag assumptions * Not all bags have only GridMap messages * Not all bags have GridMap on the right topic * Add test for trying to load a grid map from a bag that doesn't contain it on the expected topic * Add nullptr check on reader messages * Remove unused include * Don't skip reporting when tests fail (cherry picked from commit 25a1ea5) Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
* Calling pop_back on an iterator past the end is UB Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com> (cherry picked from commit 74dbbc8) Co-authored-by: Ryan <25047695+Ryanf55@users.noreply.github.com>
…botics#495) Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com> (cherry picked from commit 73d9427) Co-authored-by: Ryan <25047695+Ryanf55@users.noreply.github.com>
* We want a build after every merge to the jazzy branch Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com> (cherry picked from commit 25c9009) Co-authored-by: Ryan <25047695+Ryanf55@users.noreply.github.com>
Add industrial CI * Bring nav2 in from source on rolling * Skip rosdep keys in nav2 that don't resolve Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com> (cherry picked from commit c313843) Co-authored-by: Ryan <25047695+Ryanf55@users.noreply.github.com>
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
…apping_support [ROS2][grid_map_msgs] Added explicit ros1_bridge mapping support
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.