Extract design-independent fixes from #457 (CI tooling + graphical bug fixes)#458
Open
kcarnold wants to merge 4 commits into
Open
Extract design-independent fixes from #457 (CI tooling + graphical bug fixes)#458kcarnold wants to merge 4 commits into
kcarnold wants to merge 4 commits into
Conversation
Add an update-snapshots workflow_dispatch job to frontend-tests.yml that re-renders Playwright baselines in the pinned container and commits them back to the branch, and skip the e2e job when regenerating. Rewrite VISUAL_REGRESSION.md to document this flow and the single chromium baseline. Delete the firefox/webkit baseline PNGs, which are already dead (those Playwright projects are commented out in playwright.config.ts). Extracted from #457; no design impact.
The active feature card passed the raw string 'active' instead of the CSS-module class `classes.active`. CSS modules hash the class name, so the existing `.featureCard.active` rules never matched and the active highlight never rendered. Use `classes.active` so the already-defined styling applies.
The typing-indicator dots (#fafaf8 on a #ffffff bubble) and the disabled send button (#fafaf8 background under a near-white #faf8f4 icon) were white-on-white and invisible. Give the dots a visible neutral gray, and dim the dark send button when disabled instead of washing it out.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts non-design-dependent fixes from #457, focusing on CI tooling for Playwright visual snapshots and a couple of small UI correctness/contrast fixes in the Draft and Chat pages.
Changes:
- Adds a manual
workflow_dispatchpath to regenerate Playwright visual snapshots in CI and commit them back to the triggering branch. - Fixes Draft feature-card “active” styling by using the CSS-module class instead of a raw string.
- Improves Chat typing-indicator and disabled send-button visibility by adjusting colors/opacity, and updates
VISUAL_REGRESSION.mdto match the new snapshot workflow.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
VISUAL_REGRESSION.md |
Updates documentation to reflect CI-based snapshot regeneration and single Chromium baseline. |
frontend/src/pages/draft/index.tsx |
Fixes active-card class application for CSS modules. |
frontend/src/pages/chat/styles.module.css |
Adjusts typing dots and disabled send button styling for visibility. |
.github/workflows/frontend-tests.yml |
Adds snapshot-regeneration job and conditional skipping of E2E during regeneration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls the changes out of #457 that don't require a design decision so they can be reviewed and merged without waiting on the brand-redesign design-team meeting. Everything brand/design-related (theme tokens, fonts, navbar wordmark, copy rewrites, restyles) stays in #457.
Re-authored on top of
main(not stacked on #457) so each piece merges independently. One commit per bucket:1.
ci:visual-snapshot regeneration job + docs cleanupupdate-snapshotsworkflow_dispatchjob tofrontend-tests.ymlthat re-renders Playwright baselines in the pinned container and commits them back to the branch; skip thee2ejob when regenerating.VISUAL_REGRESSION.mdto document that flow and the single chromium baseline.playwright.config.tsonmain. (The chromium baseline is left untouched.)2.
fix(draft):apply active-card highlight classThe active feature card passed the raw string
'active'instead ofclasses.active. CSS modules hash the class name, so the.featureCard.activerules that already exist never matched and the highlight never rendered. One-line fix.3.
fix(chat):make typing dots and disabled send button visibleThe typing-indicator dots (
#fafaf8on a#ffffffbubble) and the disabled send button (#fafaf8background under a near-white#faf8f4icon) were white-on-white and invisible. Dots get a visible neutral gray; the dark send button is dimmed when disabled instead of washed out. Minimal contrast fixes against the current palette — no new design tokens.Verification
npm run build,tsc --noEmit, ESLint, and the 8 Vitest unit tests pass.Follow-up
After this merges, #457 should be rebased onto
main, shrinking it to just the design decisions. The dead-code/refactor cleanup (remove deadrevise .tabBtnstyles; replace the draft delete-button JS hover hack with CSS:hover) was intentionally left out and can be a later PR.https://claude.ai/code/session_01SmzcLwfuBPx2eL2wkNjVvk
Generated by Claude Code