Skip to content

fix: add missing all-gather for nnx vocabulary tiling #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mesakhcienet wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −3
Draft

fix: add missing all-gather for nnx vocabulary tiling #4236

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50207e2
fix: add missing all-gather for nnx vocab tiling
mesakhcienet Jun 23, 2026
ce352a4
Update base.yml
mesakhcienet Jun 23, 2026
18391f2
Revert "fix: add missing all-gather for nnx vocab tiling"
mesakhcienet Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/maxtext/configs/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,9 +1196,9 @@ position_id_per_seconds: 25
subslice_shape: ""

# NNX
enable_nnx: false
pure_nnx_decoder: false
pure_nnx: false
enable_nnx: true
pure_nnx_decoder: true
pure_nnx: true

################################## Qwen3-Next Specific Configs ##################################
# Kernel size for the 1D convolution in the Gated Delta Net
Expand Down
Loading