Fix compile_cache_test by filtering cache files for jit_train_step#4222
Open
igorts-git wants to merge 1 commit into
Open
Fix compile_cache_test by filtering cache files for jit_train_step#4222igorts-git wants to merge 1 commit into
igorts-git wants to merge 1 commit into
Conversation
…in_step. Previously, test_train_step_cache_hit asserted that the compilation cache contained exactly 1 file, assuming only would be cached. However, in some environments (like nightly workflows), JAX also caches other compiled functions (like ), causing the test to fail. This fix changes the assertion to filter the cache files for the prefix before verifying that only one compilation occurred, making the test robust against other functions being cached.
igorts-git
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
NuojCheng
approved these changes
Jun 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, test_train_step_cache_hit asserted that the compilation cache contained exactly 1 file, assuming only the
jit_train_stepwould be cached. However, in nightly workflow JAX also caches other compiled functions, causing the test to fail.This fix changes the assertion to filter the cache files for the prefix before verifying that only one compilation occurred, making the test robust against other functions being cached.
BUGS: b/517327969
Tests
Manual of the affected test
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.