Skip to content

Conversation

@xuefgu
Copy link
Collaborator

@xuefgu xuefgu commented Nov 18, 2025

Description

Enable data parallelism in RL rollout

Tests

Manually tested with 1 trainer slices and 2 samplers slices (each with 2 model replicas).

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Copy link
Collaborator

@NicoGrande NicoGrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you share the logs for your test run?

Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@copybara-service copybara-service bot merged commit 094b41d into main Dec 10, 2025
52 of 55 checks passed
@copybara-service copybara-service bot deleted the xfgu-dp-rl branch December 10, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants