feat: add speedup visualization plots and normalize arithmetic/geometric mean calculations#35
Open
shangkunwang01 wants to merge 2 commits intomainfrom
Open
feat: add speedup visualization plots and normalize arithmetic/geometric mean calculations#35shangkunwang01 wants to merge 2 commits intomainfrom
shangkunwang01 wants to merge 2 commits intomainfrom
Conversation
Collaborator
shangkunwang01
commented
May 4, 2026
shangkunwang01
commented
- Add distribution and barplot for visualize the speedup.
- Cap the speedup at 1 for mean calculation.
…ric mean calculations
NinaCai
reviewed
May 6, 2026
Collaborator
There was a problem hiding this comment.
Can we use 1.05 or 1.1 to avoid numbers like 1.00001?
Collaborator
Author
There was a problem hiding this comment.
Sure, I added a threshhold value there. It will only influence the improvement_ratio.
| max_speedup = max(improvements) if improvements else 0 | ||
| speedups_cliped = [max(speed, 1) for speed in speedups] | ||
| arithmetic_mean_speedup = ( | ||
| sum(speedups_cliped) / len(speedups_cliped) if speedups_cliped else 0 |
Collaborator
There was a problem hiding this comment.
Why do we use speedups_cliped to calculate mean?
Also, when visualize_speed_up, do you use clipped or the original?
Collaborator
Author
There was a problem hiding this comment.
- Because the optimized code can be slower than the reference code (speedup < 1) but if that is the case, we can just use the reference code. This seems to be a common practice to report results;
- In visualize_speed_up I use original so that it is easier for us to find those bad cases.
…ting improvements
NinaCai
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.