You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @stevehadd! One question before I write code: the issue refers to the classes in packages/third_party/site_archive_aws, but I can't find that folder on develop, any other branch, or anywhere in the git history. Is it on a branch or fork that hasn't been pushed yet?
In the meantime I'm using site_archive_nci/_CMIP5.py and site_archive_met_office/ERA5lowres.py as references, since the CMIP5 class looks closest in structure. Happy to switch if there's a better one.
There's quite a few different examples of accessors, which have different implementations depending on the data being accessed. Feel free to take inspiration from whichever ones you feel appropriate for the CMIP6 data. It will be helpful to provide details about the choices you make in your PR for reviewers.
Dear @stevehadd, PR is up: #287. It adds the Pangeo CMIP6 accessor (PangeoCMIP6) in packages/third_party/pangeo_site_archive, with offline tests and a docs section. The design choices and a few open questions for you are in the PR description. Happy to adjust anything.
Activity
stevehadd commentedon Oct 2, 2026
@ahmedmohiduet
ahmedmohiduet commentedon Oct 3, 2026
Thanks @stevehadd! One question before I write code: the issue refers to the classes in
packages/third_party/site_archive_aws, but I can't find that folder ondevelop, any other branch, or anywhere in the git history. Is it on a branch or fork that hasn't been pushed yet?In the meantime I'm using
site_archive_nci/_CMIP5.pyandsite_archive_met_office/ERA5lowres.pyas references, since the CMIP5 class looks closest in structure. Happy to switch if there's a better one.stevehadd commentedon Oct 3, 2026
Apologies, I've been a slower finishing that PR than I expected to be, so its still in my fork:
https://github.com/stevehadd/PyEarthTools/tree/archive_tutorial/packages/third_party/aws_site_archive
stevehadd commentedon Oct 3, 2026
There's quite a few different examples of accessors, which have different implementations depending on the data being accessed. Feel free to take inspiration from whichever ones you feel appropriate for the CMIP6 data. It will be helpful to provide details about the choices you make in your PR for reviewers.
ahmedmohiduet commentedon Oct 3, 2026
Thanks, that's exactly what I needed. I'll document the design choices in the PR.
ahmedmohiduet commentedon Oct 5, 2026
Dear @stevehadd, PR is up: #287. It adds the Pangeo CMIP6 accessor (
PangeoCMIP6) inpackages/third_party/pangeo_site_archive, with offline tests and a docs section. The design choices and a few open questions for you are in the PR description. Happy to adjust anything.