Update event comments layout and styling#616
Open
BrilliantDeviation7 wants to merge 2 commits intoABTech:masterfrom
Open
Update event comments layout and styling#616BrilliantDeviation7 wants to merge 2 commits intoABTech:masterfrom
BrilliantDeviation7 wants to merge 2 commits intoABTech:masterfrom
Conversation
Contributor
NoRePercussions
requested changes
Jan 31, 2026
Contributor
There was a problem hiding this comment.
Such an improvement! Approved modulo Tomás approval and a nit.
I'd like a clearer commit message. I know you're changing comment styling from the diff, but I can't infer the context I need to write a good review. Here's roughly what I'd have written:
fix: move comment section up to increase visibility
Resolves https://cmuabtech.slack.com/archives/CKLMNB5PX/p1766279256513539.
The comment section on event pages is below other infoboxes,
and falls below the fold when there are many notes/invoices/emails.
This results in comments getting "lost" when people don't notice
them until they're specifically sought out.
It is more important for comments to be noticeable than
other fields -- looking up notes, invoices, or emails is intentional,
whereas seeing comments is incidental. To increase visibility,
move them up above the fold.
Also includes minor stylistic changes.
Contributor
Contributor
Author
|
Thanks for the feedback; I also prefer the 3rd one because it keeps the text input's background white. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






No description provided.