Skip to content

chore: further modifications #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shaderpixel merged 3 commits into from
Nov 11, 2024
Merged

chore: further modifications #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb285f6
chore: further modifications
Shaderpixel Nov 11, 2024
24aabf8
chore: test
Shaderpixel Nov 11, 2024
6398515
fix: linter issues
Shaderpixel Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/teamwork.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,33 +195,28 @@ teamwork::pull_request_review_submitted() {
local -r review_state=$(github::get_review_state)
local -r comment=$(github::get_review_comment)

## Message when PR has been approved
## Message when PR has been approved, don't include body message
if [ "$review_state" == "approved" ]; then
teamwork::add_comment "
**$user** submitted a review to the PR: **[$pr_title]($pr_url)**

---

Review: **$review_state ✅**"
if [ -n "$comment" ]; then
teamwork::add_comment "Comment: $comment"
fi
teamwork::add_tag "PR Approved"
teamwork::remove_tag "PR Changes Requested"
teamwork::move_task_to_column "$BOARD_COLUMN_REVIEWED"
fi

## Add a message if the PR has change requested
## Add a message if the PR has change requested, include body message
if [ "$review_state" == "changes_requested" ]; then
teamwork::add_comment "
**$user** submitted a change request to the PR: **[$pr_title]($pr_url)**

---

Review: **$review_state 😔**"
if [ -n "$comment" ]; then
teamwork::add_comment "Comment: $comment"
fi
Review: **$review_state 😔**
Comment: $comment"

teamwork::add_tag "PR Changes Requested"
teamwork::remove_tag "PR Approved"
Expand All @@ -232,8 +227,10 @@ fi
teamwork::pull_request_review_dismissed() {
local -r user=$(github::get_sender_user)
teamwork::add_comment "Review dismissed by $user"
if [ -n "$comment" ]; then
teamwork::add_comment "Comment: $comment"
if [ -z "$comment" ]; then
true
else
teamwork::add_comment "Comment: $comment"
fi
teamwork::remove_tag "PR Open"
teamwork::remove_tag "PR Approved"
Expand Down