Improve error handling when scanning remotes (#84)#85
Open
komar007 wants to merge 2 commits into9999years:mainfrom
Open
Improve error handling when scanning remotes (#84)#85komar007 wants to merge 2 commits into9999years:mainfrom
komar007 wants to merge 2 commits into9999years:mainfrom
Conversation
Extra changes: - failure to find remote url -> continue to next remote (instead of err), - failure in Gerrit::new (cache error) -> err immediately (the next remote is unlikely to succeed).
komar007
force-pushed
the
fix_error_handling
branch
from
f08f5a9 to
f8c2c21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also slightly improved miette error presentation by removing the
Error:prefix generated bymain.