Skip to content

Fix catalog scan false positive and pin GitHub Actions #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
917Dhj merged 1 commit into from
Sep 27, 2026
Merged

Fix catalog scan false positive and pin GitHub Actions #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v5
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5

- name: Set up Python
uses: actions/setup-python@v6
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6
with:
python-version: "3.11"
cache: "pip"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-star-history.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v5
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5

- name: Generate static star history
run: python3 scripts/generate_star_history.py
Expand Down
6 changes: 3 additions & 3 deletions tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,15 +988,15 @@ def test_domain_rules_missing_or_invalid_falls_back(tmp_path: Path, monkeypatch)
def test_env_config_value_falls_back_to_shell_file(tmp_path: Path, monkeypatch) -> None:
shell_file = tmp_path / ".zshenv"
shell_file.write_text(
'\n# comment\nexport DEEPPAPERNOTE_SEMANTIC_SCHOLAR_API_KEY="file_based_key"\n',
'\n# comment\nexport DEEPPAPERNOTE_SEMANTIC_SCHOLAR_API_KEY="redacted"\n',
encoding="utf-8",
)
monkeypatch.delenv("DEEPPAPERNOTE_SEMANTIC_SCHOLAR_API_KEY", raising=False)
monkeypatch.delenv("SEMANTIC_SCHOLAR_API_KEY", raising=False)
monkeypatch.setattr("common.SHELL_CONFIG_FILES", [shell_file])

assert env_config_value("DEEPPAPERNOTE_SEMANTIC_SCHOLAR_API_KEY") == "file_based_key"
assert semantic_scholar_headers()["x-api-key"] == "file_based_key"
assert env_config_value("DEEPPAPERNOTE_SEMANTIC_SCHOLAR_API_KEY") == "redacted"
assert semantic_scholar_headers()["x-api-key"] == "redacted"


def test_check_environment_reports_semantic_scholar_key_from_env(tmp_path: Path) -> None:
Expand Down