Fix proxy cleanup during rapid WebSocket reconnects#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When the firmware reconnects very quickly, the new WebSocket connection can be accepted before the previous connection finishes closing. Because the server tracks connections by client IP, the old connection's cleanup could remove the newly registered proxy. As a result,
GET /v1/stackchanand related endpoints could incorrectly report that no StackChan was connected.Fix
This change makes proxy registration and removal atomic and identity-aware:
_register_proxy()stores the new proxy under the client IP while holding a lock_unregister_proxy()removes the mapping only if the proxy being cleaned up is still the active one for that IPThis preserves the latest connection across fast reconnects and keeps the REST API state consistent.
Testing
stackchan_server/app.py