You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when in insert mode and the suggest panel(autocomplete) shows up, hitting escape will close the suggest panel and switch to normal mode.
This change allows the user to only close the suggest panel. To go to normal mode, the user would have to hit escape again.
A situation where this is helpful is when the suggest panel pop up together with github copilot suggestion. We want to stay in insert mode to accept github copilot suggestion
package.json is automatically generated and should not be modified. Instead, this line should be modified as it defines the keybinding.
Currently, dance.modes.set.normal runs the command hideSuggestWidget (see link above), so it is somewhat expected that the suggest widget might be opened when switching from insert mode to normal mode. I do agree that it would be better to instead close the suggest widget on escape, but this is somewhat of a breaking change.
I suppose the change needed to do that is
- * | Set mode to Normal | `set.normal` | `escape` (kakoune: insert), `escape` (helix: select) | `[".modes.set", { mode: "normal" }], ["hideSuggestWidget"]` |
+ * | Set mode to Normal | `set.normal` | `escape` (kakoune: insert, "!suggestWidgetVisible"), `escape` (helix: select) | `[".modes.set", { mode: "normal" }]` |
(with the table is reformatted).
And because VS Code keybindings interact in fairly complex ways, this should be tested (locally, no need to add a test) to be sure this works as expected. And CHANGELOG.md should mention the change, with a snippet to restore the previous behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when in insert mode and the suggest panel(autocomplete) shows up, hitting escape will close the suggest panel and switch to normal mode.
This change allows the user to only close the suggest panel. To go to normal mode, the user would have to hit escape again.
A situation where this is helpful is when the suggest panel pop up together with github copilot suggestion. We want to stay in insert mode to accept github copilot suggestion