Skip to content

fix: extend Diagnostic Report to cover extension function events#8438

Open
malec-palec wants to merge 2 commits into4ian:masterfrom
malec-palec:fix/diagnostic-report-edge-cases
Open

fix: extend Diagnostic Report to cover extension function events#8438
malec-palec wants to merge 2 commits into4ian:masterfrom
malec-palec:fix/diagnostic-report-edge-cases

Conversation

@malec-palec
Copy link
Contributor

Diagnostic Report previously only scanned layout (scene) events and external events for validation errors. This PR extends the JavaScript validation scanner to also scan events inside extension functions - including top-level (free) functions, behavior functions, and object functions - detecting missing instructions and invalid parameters.

  • Store-installed extensions are excluded from the scan
  • Disabled (commented out) events and their sub-events are skipped everywhere, not just in extensions
  • Report items for extension errors show the extension and function name as location, and clicking them opens the extension editor focused on the relevant function and event
  • Tests added for extension function scanning, disabled event skipping, and extension error grouping

@4ian
Copy link
Owner

4ian commented Mar 25, 2026

Hi @malec-palec! Let me know once this is ready for review.

@malec-palec malec-palec marked this pull request as ready for review March 25, 2026 17:57
@malec-palec malec-palec requested a review from 4ian as a code owner March 25, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants