Correlate traces and dependencies with the same Operation Id - #157
Merged
Conversation
ivan-nikalaichanka-4ss
added
the
chore
ivan-nikalaichanka-4ss
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure manual tracing/logging and automatically tracked dependencies (e.g., HTTP client spans) share the same Azure Application Insights Operation Id by introducing an explicit OpenTelemetry span around the timed client operations and centralizing metric logger setup.
Changes:
- Add an OpenTelemetry span around
_timer-decorated client methods so dependency telemetry is correlated under the same operation. - Move metric logger initialization/configuration into
datareservoirio/_logging.py(get_metric_logger) and updateclient.pyto use it. - Remove now-redundant metric-logger/configuration code from
client.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| datareservoirio/client.py | Wrap timed client operations in a current span and emit metrics via the centralized metric logger. |
| datareservoirio/_logging.py | Introduce get_metric_logger() to configure and return the metrics logger used for telemetry emission. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
branislav-jenco-4ss
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-4340
Description
Wrap the function's logic in an OpenTelemetry span so the manual log entry and auto-tracked HTTP calls dependencies it produces share the same Operation Id in Application Insights.
Checklist