fix(gate): wire check-retired-claims into CI — the AD-030 gate existed but never ran - #477
Merged
Merged
Conversation
…d but never ran check-retired-claims.cjs and its 9 tests merged in #469, but nothing invoked them: not test:scripts, not the validate chain. .ai/RULES.md and AGENTS.md already assert this enforcement exists, so until now the gate was a script anyone could regress past without CI noticing. Three lines in package.json close it: validate:retired-claims script, check-retired-claims.test.cjs in test:scripts, and the gate inserted at the front of the validate chain (it is sub-second — fail fast before the heavy steps). Verified in this worktree: gate OK repo-wide, 9/9 tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBY5q2MskiKMkTm6NmB49L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The residual this closes
scripts/check-retired-claims.cjs+ its 9 tests merged in #469 as the AD-030 enforcement gate — but nothing ever invoked them. Nottest:scripts, not thevalidatechain, so the gate never ran in CI. Meanwhile.ai/RULES.md/AGENTS.md(via #431) already assert this enforcement exists. This was the priority residual of the AD-030 retirement arc (tracked in.claude/plans/PENDING-DECISION.mditem 1); it was blocked on #470's lane holdingpackage.jsonand is unblocked now that #470 merged.Change (3 lines, package.json only)
validate:retired-claimsscript →node scripts/check-retired-claims.cjsscripts/check-retired-claims.test.cjsadded totest:scriptsvalidatechain, right after the size check — it is sub-second, so it fails fast before the heavy stepsVerification
node scripts/check-retired-claims.cjs— OK repo-wide (0 violations)node --test scripts/check-retired-claims.test.cjs— 9 pass / 0 fail🤖 Generated with Claude Code
https://claude.ai/code/session_01LBY5q2MskiKMkTm6NmB49L