[BAC-1267] Compile the JSON attribute assigner per exact class - #23
Merged
Conversation
yard
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsers::JSONgeneratedassign_attributes_from_jsonviamethod_missing, defining it on the class of the first instance that parsed JSON. Subclasses inherited that compiled method,method_missingnever fired for them, and subclass-only attributes were silently dropped for the lifetime of the process:In karen this loses
BusyFallback#transcripton every Redis round-trip once a receptionist config has been parsed (any live process), and makes specs order-dependent.The assigner is now compiled once per exact class — memoized in a class-level ivar, which is not inherited — and dispatched through a stable module method, so a superclass's compiled assigner can never shadow subclass attributes.
Also bumps nokogiri in the dev lockfile (1.16.6 no longer builds on current macOS).