[BAC-273] Stringify keys in from_json call - #18
Merged
Conversation
HolyWalley
reviewed
Jul 8, 2025
| # Class-level methods. | ||
| module ClassMethods | ||
| def from_json(json) | ||
| unified_json = json.stringify_keys |
Contributor
There was a problem hiding this comment.
deep stringify keys? Or nested entities will be handled by their own from_json?
Contributor
There was a problem hiding this comment.
will with_indifferent_access be a better/faster alternative?
Contributor
Author
There was a problem hiding this comment.
There is no method with_indifferent_access an instance of ActionController::Parameters
yard
approved these changes
Jul 23, 2025
| person = ParsersTest::Person.from_json(source) | ||
|
|
||
| expect(person).to be_valid | ||
| expect(person.as_json.deep_symbolize_keys).to eq({ |
Contributor
There was a problem hiding this comment.
should it just be to eq(source)?
Contributor
Author
There was a problem hiding this comment.
nope, source have camelized keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☝️