-
Notifications
You must be signed in to change notification settings - Fork 0
[BAC-336] Move AJ serializer to AME from voices #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # This file is only loaded when explicitly required or when Rails/ActiveJob is present | ||
| # It provides ActiveJob serialization support for ActiveModel::Entity objects | ||
|
|
||
| if defined?(ActiveJob) | ||
| module ActiveJob | ||
| module Serializers | ||
| # Handles serialization of all ActiveModel::Entity classes. | ||
| class ActiveModelSerializer < ActiveJob::Serializers::ObjectSerializer | ||
| def serialize?(argument) | ||
| argument.is_a?(ActiveModel::Entity) | ||
| end | ||
|
|
||
| def serialize(argument) | ||
| super( | ||
| "type" => argument.class.name, | ||
| "json" => argument.class.represent(argument), | ||
| ) | ||
| end | ||
|
|
||
| def deserialize(hash) | ||
| hash["type"].constantize.from_json(hash["json"]) | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module ActiveModel | ||
| module Entity | ||
| # Railtie to integrate with Rails and ActiveJob | ||
| class Railtie < Rails::Railtie | ||
| initializer "activemodel_entity.configure_active_job_serializer" do | ||
| require "active_model/entity/active_job" | ||
|
|
||
| if defined?(ActiveJob::Serializers::ActiveModelSerializer) | ||
| Rails.application.config.to_prepare do | ||
| Rails.application.config.active_job.custom_serializers << ActiveJob::Serializers::ActiveModelSerializer | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require "spec_helper" | ||
|
|
||
| require "active_job" | ||
| require "active_model/entity/active_job" | ||
| require "active_job/arguments" | ||
|
|
||
| ActiveJob::Serializers.add_serializers(ActiveJob::Serializers::ActiveModelSerializer) | ||
|
|
||
| RSpec.describe ActiveJob::Serializers::ActiveModelSerializer do | ||
| subject(:entity) { klass.new(text: "hello", number: 1) } | ||
|
|
||
| let(:klass) do | ||
| Class.new do | ||
| include ActiveModel::Entity | ||
|
|
||
| attribute :text, :string | ||
| attribute :number, :integer | ||
| end | ||
| end | ||
|
|
||
| before do | ||
| stub_const("MyClass", klass) | ||
| end | ||
|
|
||
| it "serializes things back and forth" do | ||
| expect(ActiveJob::Arguments.deserialize(ActiveJob::Arguments.serialize([entity]))).to eq([entity]) | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent duplicate registrations on each
to_preparerun (e.g., in development reloads), guard this with an inclusion check, e.g.:unless config.active_job.custom_serializers.include?(...).