[BAC-274] Cast ActionController::Parameters into hash during parsing …

[taleh007]

…json

[Copilot]

Pull Request Overview

This PR ensures that ActionController::Parameters objects are converted into plain Hashes during JSON parsing in ActiveModel entities, and adjusts equality and hashing logic to operate on JSON-serializable representations.

• Adds a spec to verify conversion of ActionController::Parameters to a Hash when parsing JSON.
• Updates Equality#eql? to compare attributes.as_json and revises hash to include values instead of duplicate keys.
• Introduces cast_json wrapper in ActiveModel::Type::Value to call to_unsafe_h on parameter objects before casting.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
spec/active_model/entity/parsers/json_spec.rb	Added test for converting ActionController::Parameters to Hash
lib/active_model/entity/equality.rb	Use attributes.as_json in eql? and fix hash to include attributes.values
lib/active_model/entity/attribute.rb	Define cast_json to convert params via to_unsafe_h before calling cast

Comments suppressed due to low confidence (1)

lib/active_model/entity/attribute.rb:6

• There’s no existing spec for the new cast_json method to ensure it correctly converts ActionController::Parameters to a hash before casting. Consider adding a unit test in spec/active_model/entity/attribute_spec.rb to cover this behavior.

  def cast_json(value)

[Copilot]

The hash method uses attributes.keys and attributes.values in insertion order, which may lead to inconsistent hash values for logically equal objects if key ordering differs. Consider sorting the keys and pairing each key with its corresponding value to ensure a stable hash for equal attribute sets.

Suggested change

	[self.class, *attributes.keys, *attributes.values].hash
	sorted_attributes = attributes.keys.sort.map { |key| [key, attributes[key]] }
	[self.class, *sorted_attributes].hash