fix(3scale_batcher): handle string values#1597
Open
tkan145 wants to merge 1 commit into
Open
Conversation
When configuring the auths_ttl and batch_report_seconds values a batch processing policy to string instead of integer, the policy will silently fail unless APICAST_VALIDATE_POLICY_CONFIGS is set. Enabling APICAST_VALIDATE_POLICY_CONFIGS is currently too risky as it will cause existing policies configured with the wrong data type to fail. A safer approach is to try converting the values numbers, then fallback to the default value when the input data is invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix https://redhat.atlassian.net/browse/THREESCALE-15547
Verification steps