Perf: Batcher policy refactor#1583
Open
tkan145 wants to merge 5 commits into
Open
Conversation
New keys can be added by concurrent requests. And keys read by get_keys() can be incremented by add() between read and delete operations, resulting in the loss of those increments. Therefore, moving get_keys() inside the lock to prevent a race condition as add() will block on the same service_id lock.
Each key is matched against all 4 regex pattern, credential type can be extract directly from key, so refactoring to avoid lookup loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBA