This repository was archived by the owner on May 6, 2026. It is now read-only.
fix: raise ValueError instead of silent sys.exit(1) for empty deck data#116
Merged
fix: raise ValueError instead of silent sys.exit(1) for empty deck data#116
Conversation
Filter out non-existent media files before passing to genanki, so users still get their flashcards even if images are missing from the upload.
sys.exit(1) raises SystemExit which is not caught by the except Exception block, so failures from empty pages produced no output and no error email. Replacing with ValueError gives the caller a useful message in stderr and triggers the production error email flow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
stdout is the machine-readable channel — it carries only the final .apkg file path. Warnings and error messages going to stdout could corrupt that output and cause the Node.js caller to resolve with a warning string instead of a valid path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.exit(1)raisesSystemExit, which is aBaseException— not caught by theexcept Exceptionblock"Python script exited with code 1: (no output)"with nothing to debugValueErrorwith a clear message so the except block catches it, logs it to stderr, and sends the production error emailTest plan
🤖 Generated with Claude Code