fix: save intermediate tool messages to prevent missing tool_result errors#459
Open
ahmed-sekka wants to merge 1 commit into2FastLabs:mainfrom
Open
fix: save intermediate tool messages to prevent missing tool_result errors#459ahmed-sekka wants to merge 1 commit into2FastLabs:mainfrom
ahmed-sekka wants to merge 1 commit into2FastLabs:mainfrom
Conversation
…rrors (awslabs#396) When BedrockLLMAgent uses tools, the intermediate toolUse/toolResult conversation messages were only kept in a local list and never persisted to storage. This caused subsequent requests to fail with Bedrock validation errors about missing tool_result blocks. Changes: - BedrockLLMAgent now collects intermediate tool messages in tool_conversation during both single and streaming responses - Orchestrator saves these intermediate messages to storage alongside user input and final response - When max_recursions is exhausted, toolUse blocks are stripped from the response to prevent saving orphaned toolUse without toolResult
Collaborator
|
Thanks for you PR, we will review it and provide feedback. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #396
When
BedrockLLMAgentuses tools, the intermediatetoolUse/toolResultconversation messages were only kept in a local list and never persisted to storage. This caused subsequent requests to fail with Bedrock validation errors about missingtool_resultblocks.BedrockLLMAgentnow collects intermediate tool messages intool_conversationduring both single and streaming responsesOrchestratorsaves these intermediate messages to storage alongside user input and final responsemax_recursionsis exhausted,toolUseblocks are stripped from the response to prevent saving orphanedtoolUsewithouttoolResultTest plan
BedrockLLMAgenttool message collection (test_bedrock_llm_agent.py)Orchestratorintermediate message persistence (test_orchestrator.py)BedrockLLMAgent+DynamoDBStorageno longer raiseValidationException🤖 Generated with Claude Code