fix(orchestrator): pass MAX_MESSAGE_PAIRS_PER_AGENT in streaming path#443
Open
guoyangzhen wants to merge 1 commit into2FastLabs:mainfrom
Open
fix(orchestrator): pass MAX_MESSAGE_PAIRS_PER_AGENT in streaming path#443guoyangzhen wants to merge 1 commit into2FastLabs:mainfrom
guoyangzhen wants to merge 1 commit into2FastLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Streaming responses do not respect MAX_MESSAGE_PAIRS_PER_AGENT configuration (#365). The processStreamInBackground method calls saveConversationExchange without the maxHistorySize parameter, causing unbounded conversation history growth.
Fix
Added the missing this.config.MAX_MESSAGE_PAIRS_PER_AGENT parameter to the saveConversationExchange call in the streaming code path.
Non-streaming path already passed this parameter correctly.
Changes
Closes #365