fix(browser): use 'open -a Firefox' for XPI install on macOS#335
Open
udiedrichsen wants to merge 1 commit into
Open
fix(browser): use 'open -a Firefox' for XPI install on macOS#335udiedrichsen wants to merge 1 commit into
udiedrichsen wants to merge 1 commit into
Conversation
The previous code used plain 'open' on the .xpi file URL, but macOS has no default handler for .xpi files, causing kLSApplicationNotFoundErr. Now we explicitly open with Firefox via , with a fallback to .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
jcode browser setupfailing on macOS withkLSApplicationNotFoundErrwhen trying to open the Firefox extension (.xpi) installer.Problem
The previous code called
open <file-url>on the.xpifile, but macOS has no default handler for.xpifiles. This produces:Fix
Use
open -a Firefox <file-url>to explicitly open the XPI with Firefox, which knows how to handle Firefox extension installation. Falls back toopen -b org.mozilla.firefoxas a secondary option.Changes
crates/jcode-base/src/browser.rsopenwithopen -a Firefoxin the macOS#[cfg]block ofinstall_extension()Validation
open -a Firefoxpattern is the standard recommended approach for opening files with a specific application on macOSCloses #334