[CI] Pin reviewed Node 24 action releases - #102
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal and scope
Refs #101. Replace the old Node 20 action pins with immutable official Node 24 releases, resolving the forced-runtime warnings observed in Public CI run https://github.com/1XP-AI/gh-runnerd/actions/runs/36234842829.
actions/checkoutv7.0.1:3d3c42e5aac5ba805825da76410c181273ba90b1actions/setup-gov7.0.0:b7ad1dad31e06c5925ef5d2fc7ad053ef454303epersist-credentials: false,cache: false, and all existing checks. No unsafe checkout opt-in.Actual validation
Candidate:
883c660a15cec1d1a13e572ac9f9ee89357cfa24.TDD red: after changing the existing expected pins but before changing workflows,
GOTOOLCHAIN=go1.26.8 go test -run '^TestPublicWorkflowCapacityContract$' -count=1 ./scriptsexited 1 with eight expected pin mismatches across root/race/offline/vuln jobs.Green after implementation:
Focused tests passed (0.301s), all modules verified, one-module license inventory verified, and whitespace checks passed. No local full suite, live runner test, credential operation, or workflow dispatch/replay was performed.
Review and remaining gates
9636e33781c72c32319db419334f49f1bc1866bc. Automatic postmerge Public CI passed all seven jobs: https://github.com/1XP-AI/gh-runnerd/actions/runs/36236548788 . Every job's check annotations were inspected and empty; the prior forced Node 20 runtime warning is absent. No manual dispatch/replay.Official release/manifests/licenses and compatibility evidence are recorded in
docs/DEPENDENCIES.md. Checkout v7 unsafe-event protection does not change this repository'spull_requesttrigger; setup-go v7 retains the used inputs. Cache remains disabled.Rollback: reviewed revert of the resulting merge commit. No G01/G02 live evidence gate or production implementation is claimed complete.