Repository navigation
Add Ansible vault plugin - #382
Open
SimonBarendse wants to merge 12 commits into
Open
SimonBarendse wants to merge 12 commits into
SimonBarendse wants to merge 12 commits into
Conversation
Remove the need for string manipulation and instead return the password field directly, to simplify the code for readability.
This should fix the lint CI job as well.
This was caught by the test which failed because of this missing newline.
This is where the importer expects the file as well
accraw
approved these changes
Oct 16, 2023
accraw
left a comment
accraw
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me - I ran the tests I could without having a working sensible setup
AndyTitu
reviewed
Oct 17, 2023
AndyTitu
reviewed
Oct 17, 2023
AndyTitu
left a comment
AndyTitu
left a comment
Contributor
There was a problem hiding this comment.
Code lgtm mostly but left one question
florisvdg
reviewed
Oct 17, 2023
| @@ -0,0 +1,25 @@ | |||
| package ansiblevault | |||
Contributor
There was a problem hiding this comment.
I'd call the plugin ansible. The ansible-vault CLI is shipped as part of the ansible package.
Contributor
There was a problem hiding this comment.
Wouldn't that be confusing if we add the ansible CLI as well? Or are you just suggesting we rename the package? It looks like there are 9 CLIs: https://docs.ansible.com/ansible/latest/command_guide/command_line_tools.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded on #362, just added tests and fixed bugs that uncovered.