Skip to content

fix: improve model editing logic and handle missing workspace_id gracefully #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxg0103 merged 1 commit into from
Oct 15, 2026
Merged

fix: improve model editing logic and handle missing workspace_id gracefully #7341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/models_provider/serializers/model_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@

import uuid_utils.compat as uuid
from common.config.embedding_config import ModelManage
from common.constants.cache_version import Cache_Version
from common.constants.resource_permission_constants import ResourceAuthType
from common.database_model_manage.database_model_manage import DatabaseModelManage
from common.db.search import native_search
from common.exception.app_exception import AppApiException
from common.utils.common import get_file_content
from common.utils.rsa_util import rsa_long_decrypt, rsa_long_encrypt
from django.core.cache import cache
from django.db import transaction
from django.db.models import QuerySet
from django.utils.translation import gettext_lazy as _
Expand Down Expand Up @@ -207,9 +204,12 @@ def delete(self, with_valid=True):

def edit(self, instance: Dict, user_id: str, with_valid=True):
if with_valid:
self.is_valid(raise_exception=True)
model = QuerySet(Model).filter(id=self.data.get("id"), workspace_id=self.data.get("workspace_id")).first()

super().is_valid(raise_exception=True)
model = (
QuerySet(Model)
.filter(id=self.data.get("id"), workspace_id=self.data.get("workspace_id", "None"))
.first()
)
credential, model_credential, provider_handler = ModelSerializer.Edit(data={**instance}).is_valid(
model=model
)
Expand Down
Loading