fix: After the user asks a question, a blank bar will appear stuck.#4881
fix: After the user asks a question, a blank bar will appear stuck.#4881shaohuzhang1 merged 1 commit intov2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| .trim().length == 0 | ||
| " | ||
| :source="$t('chat.tip.answerMessage')" | ||
| ></MdRenderer> |
There was a problem hiding this comment.
There seems to be a logical error in the conditional check. The additional condition that checks if answer_text has no characters after trimming is redundant because it essentially duplicates the initial check that verifies if answer_text is empty:
(v-if="(
(chatRecord.write_ed === undefined || chatRecord.write_ed === true) &&
answer_text.length == 0
)")Here's a cleaner version of the code without the unnecessary part:
<v-if="
(chatRecord.write_ed === undefined || chatRecord.write_ed === true) &&
answer_text.length == 0
">
<MdRenderer
:source="$t('chat.tip.answerMessage')"
/>
</v-if>This removes the repeated check for an entirely empty string, simplifying the logic while maintaining functionality.
fix: After the user asks a question, a blank bar will appear stuck.