Skip to content

fix: After the user asks a question, a blank bar will appear stuck.#4881

Merged
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_chat
Mar 16, 2026
Merged

fix: After the user asks a question, a blank bar will appear stuck.#4881
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_chat

Conversation

@shaohuzhang1
Copy link
Contributor

fix: After the user asks a question, a blank bar will appear stuck.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 16, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 2b71e1b into v2 Mar 16, 2026
3 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_chat branch March 16, 2026 03:38
.trim().length == 0
"
:source="$t('chat.tip.answerMessage')"
></MdRenderer>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a logical error in the conditional check. The additional condition that checks if answer_text has no characters after trimming is redundant because it essentially duplicates the initial check that verifies if answer_text is empty:

(v-if="(
    (chatRecord.write_ed === undefined || chatRecord.write_ed === true) &&
        answer_text.length == 0
)")

Here's a cleaner version of the code without the unnecessary part:

<v-if="
    (chatRecord.write_ed === undefined || chatRecord.write_ed === true) &&
        answer_text.length == 0
">
    <MdRenderer
        :source="$t('chat.tip.answerMessage')"
    />
</v-if>

This removes the repeated check for an entirely empty string, simplifying the logic while maintaining functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant